New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(workqueue): deflake TestMetrics #94556
Conversation
Signed-off-by: knight42 <anonymousknight96@gmail.com>
/cc @liggitt |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knight42, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-soon |
TestClientReceivedGOAWAY flake /retest |
Unrelated TestInitialSync flake in pkg/proxy/config in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/94556/pull-kubernetes-bazel-test/1302309891905425412, will open a separate issue for that /retest |
Signed-off-by: knight42 anonymousknight96@gmail.com
What type of PR is this?
/kind flake
What this PR does / why we need it:
We need to ensure
kubernetes/staging/src/k8s.io/client-go/util/workqueue/metrics.go
Line 141 in 1f708f6
mp.longest.gaugeValue()
.Which issue(s) this PR fixes:
Fixes #94545
Part of #94528
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: