Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubernetes_lite.go: remove image argument from SpreadServiceOrFail #94655

Closed
adtac opened this issue Sep 9, 2020 · 1 comment · Fixed by #94782
Closed

ubernetes_lite.go: remove image argument from SpreadServiceOrFail #94655

adtac opened this issue Sep 9, 2020 · 1 comment · Fixed by #94782
Assignees
@adtac
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@adtac
Copy link
Member

adtac commented Sep 9, 2020

kubernetes/test/e2e/scheduling/ubernetes_lite.go

Line 68 in 47c4507

func SpreadServiceOrFail(f *framework.Framework, replicaCount int, image string) {

It's not being used. Alternatively, pass the right image name to start with.

/assign
/sig scheduling
/sig testing
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 9, 2020
@neolit123
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 9, 2020
@adtac adtac mentioned this issue Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adtac adtac

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ubernetes_lite.go: remove image argument from SpreadServiceOrFail adtac/kubernetes
3 participants
@neolit123 @adtac @k8s-ci-robot