-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpu device plugin uses EnsureExists addon mode #94726
gpu device plugin uses EnsureExists addon mode #94726
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @pradvenkat! |
Hi @pradvenkat. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ca28138
to
00ecbcc
Compare
/release-note-none |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pradvenkat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.20 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR changes the nvidia GPU device plugin addon from
Reconcile
toEnsureExists
mode.This is needed since the device plugin runs on a large number of nodes, it's almost certain there would be edge cases which causes the device plugin to fail (due to things like OOMs). While investigating and fixing root causes could take longer, changing the mode to
EnsureExists
provides a mitigation to these failure scenarios by allowing resource requests to be increased per cluster.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: