Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests related to HTTPS support for ingress-gce #94731

Merged
merged 1 commit into from Sep 12, 2020
Merged

Remove tests related to HTTPS support for ingress-gce #94731

merged 1 commit into from Sep 12, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 11, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove test which were moved to ingress-gce repo as part of kubernetes/ingress-gce#671

This is a redo of #75840
which has fallen stale and needed a rebase

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 11, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test sig/network Categorizes an issue or PR as relevant to SIG Network. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Sep 11, 2020

/milestone v1.20
/cc rramkumar1 MrHohn bowei
since you were all involved with kubernetes/ingress-gce#671

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 11, 2020
@spiffxp spiffxp mentioned this pull request Sep 11, 2020
Closed
MrHohn
MrHohn approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 66334f0 into kubernetes:master Sep 12, 2020
@spiffxp spiffxp deleted the rm-http-ingress-gce-tests branch September 15, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@cmluciano cmluciano Awaiting requested review from cmluciano

@freehan freehan Awaiting requested review from freehan

@bowei bowei Awaiting requested review from bowei

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spiffxp @k8s-ci-robot @fejta-bot @MrHohn