Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Switch cos version to M85"" #94784

Merged
merged 2 commits into from Sep 25, 2020
Merged

"Switch cos version to M85"" #94784

merged 2 commits into from Sep 25, 2020

Conversation

vteratipally
Copy link
Contributor

switch cos version to M85 to update the containerd version

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @vteratipally. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2020
@liggitt
Copy link
Member

liggitt commented Sep 15, 2020

/cc @cheftako

@wojtek-t
Copy link
Member

switch cos version to M85 to update the containerd version

What are the notable changes in the new containerd version?

@dims
Copy link
Member

dims commented Sep 15, 2020

/ok-to-test
/approve

will leave others (@cheftako ?) to lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020
@vteratipally
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2020
@vteratipally
Copy link
Contributor Author

Will remove donotmerge label once the tests https://testgrid.k8s.io/sig-node-critical#containerd-NodeConformance become successful after confirming the containerd/cri#1577.

@vteratipally
Copy link
Contributor Author

With containerd 1.4 upgrade, kubernetes could support image filesystem optimized for fast image imports, fast application “cold start” times

@wojtek-t
Copy link
Member

With containerd 1.4 upgrade, kubernetes could support image filesystem optimized for fast image imports, fast application “cold start” times

Thanks - that makes perfect sense.

My only question is when can we expect official release to avoid using RC.

@cheftako
Copy link
Member

/assign @karan

@karan
Copy link
Contributor

karan commented Sep 15, 2020

Should this wait until 85 is LTS/stable?

@vteratipally
Copy link
Contributor Author

/assign @bsdnet

@bsdnet
Copy link
Contributor

bsdnet commented Sep 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@vteratipally
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2020
@bsdnet
Copy link
Contributor

bsdnet commented Sep 15, 2020

To reply all:
All known issues (containerd 1.4, cloud-init, python2) found recently are root caused and resolved.
We will mark M85 as stable this week if no further issue found. We should be fine to use M85 in upstream.

This will also enable more upper layer features which will depend on 5.4 kernel

@bsdnet
Copy link
Contributor

bsdnet commented Sep 15, 2020

@wojtek-t
For containerd changes , see https://github.com/containerd/containerd/releases

@wojtek-t
Copy link
Member

@vteratipally @bsdnet - thanks (that sounds reasonable to me).

That said, given I have your attention here - there seem to be one more issue of previous containerd versions - see this one: #94256 (comment)
Do you know if this one has been fixed too? If not, could you please help with making that happen?

@bsdnet
Copy link
Contributor

bsdnet commented Sep 17, 2020

@wojtek-t

Let me ask around and see whether this affects containerd 1.4.x we are included in M85

@bsdnet
Copy link
Contributor

bsdnet commented Sep 17, 2020

@karan

Do you or your team have insights on #94256 @wojtek-t mentioned here?

@bsdnet
Copy link
Contributor

bsdnet commented Sep 22, 2020

/assign @karan @cheftako

Please help connect right people for PR #94256

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@vteratipally
Copy link
Contributor Author

cos-85 stable version is released with containerd 1.4.1, updating the stable version

@bsdnet
Copy link
Contributor

bsdnet commented Sep 25, 2020

/lgtm

cos 85 is marked as stable and is available to public.

$ gcloud compute images list |grep cos-cloud
cos-73-11647-656-0 cos-cloud cos-73-lts READY
cos-77-12371-1079-0 cos-cloud cos-77-lts READY
cos-81-12871-1200-0 cos-cloud cos-81-lts READY
cos-85-13310-1041-9 cos-cloud cos-85-lts READY
cos-beta-85-13310-1041-1 cos-cloud cos-beta READY
cos-dev-86-15184-0-0 cos-cloud cos-dev READY
cos-stable-85-13310-1041-9 cos-cloud cos-stable READY

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@vteratipally
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@vteratipally
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@dims
Copy link
Member

dims commented Sep 25, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2020
@dims
Copy link
Member

dims commented Sep 25, 2020

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2020
@dims
Copy link
Member

dims commented Sep 25, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3777ca7 into kubernetes:master Sep 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt Awaiting requested review from mm4tt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@karan karan

@bsdnet bsdnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@vteratipally @k8s-ci-robot @liggitt @wojtek-t @dims @cheftako @karan @bsdnet