netpol: Add CRUD tests for NetworkPolicy API

[cmluciano]

What type of PR is this?
/kind feature
/area conformance
/area test

What this PR does / why we need it:

• Adds CRUD API tests for the V1 NetworkPolicy suitable for promotion to conformance.
• CRUD operations are the extent of conformance testing that we can add
  for NetworkPolicy tests since we require a 3rd party plugin like CNI for enforcement.

Which issue(s) this PR fixes:
xref: #94776

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[cmluciano]

/sig network

[jayunit100]

@cmluciano any thoughts on how we might coordinate on #91592 (implements the KEP in flight to overhaul) ?

[jayunit100]

oh wait,

i was worried these were new policies validation tests, but it seems like theyre just doing API stuff...

maybe this works as a standalone test, since it doesnt actually test the policies ...

[cmluciano]

feedback comments

[cmluciano]

@jayunit100 Yes these are minimal tests that will eventually be promoted to conformance testing. These tests don't require the plugin and should not cause conflict in a non-fresh cluster.

[aojea]

/lgtm

it runs in the CI and pass

�[90m------------------------------�[0m
[BeforeEach] [sig-network] NetworkPolicy API
  test/e2e/framework/framework.go:174
�[1mSTEP�[0m: Creating a kubernetes client
Sep 29 17:54:48.153: INFO: >>> kubeConfig: /root/.kube/kind-test-config
�[1mSTEP�[0m: Building a namespace api object, basename networkpolicies
�[1mSTEP�[0m: Waiting for a default service account to be provisioned in namespace
[It] should support creating NetworkPolicy API operations
  test/e2e/network/network_policy.go:2285
�[1mSTEP�[0m: getting /apis
�[1mSTEP�[0m: getting /apis/networking.k8s.io
�[1mSTEP�[0m: getting /apis/networking.k8s.iov1
�[1mSTEP�[0m: creating
�[1mSTEP�[0m: getting
�[1mSTEP�[0m: listing
�[1mSTEP�[0m: watching
Sep 29 17:54:48.392: INFO: starting watch
�[1mSTEP�[0m: cluster-wide listing
�[1mSTEP�[0m: cluster-wide watching
Sep 29 17:54:48.427: INFO: starting watch
�[1mSTEP�[0m: patching
�[1mSTEP�[0m: updating
Sep 29 17:54:48.471: INFO: waiting for watch events with expected annotations
Sep 29 17:54:48.471: INFO: saw patched and updated annotations
�[1mSTEP�[0m: deleting
�[1mSTEP�[0m: deleting a collection
[AfterEach] [sig-network] NetworkPolicy API
  test/e2e/framework/framework.go:175
Sep 29 17:54:48.607: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready
�[1mSTEP�[0m: Destroying namespace "networkpolicies-8160" for this suite.

[cmluciano]

@danwinship Does this look good to you?

[danwinship]

I guess? I don't know a lot about conformance requirements. Are there other APIs where we do something like this?

[andrewsykim]

I don't think any of the tests here are being added to conformance yet, though I do think they should be promoted in the future once the tests have baked for a bit (similar to the Ingress API tests). @cmluciano was the intention to add these to conformance in this PR?

[danwinship]

He said "suitable for promotion to conformance" so I assume the intention wasn't to make them conformance in this PR. But I was just saying I have no idea if these are actually "suitable for promotion to conformance"...

[andrewsykim]

Thanks for clarifying :)

I would think these tests are suitable given the Ingress API tests are in conformance today. @johnbelamaric @dims do you foresee any issues promoting these to conformance at some point in the future?

[cmluciano]

Yes the plan was to promote these to conformance after they are successful for a few weeks. I believe the tests are suitable for promotion since they follow the same conventions and format as the ones I added for Ingress API conformance with #91830

[andrewsykim]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, cmluciano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/network/OWNERS [andrewsykim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cmluciano]

/retest

[cmluciano]

/kind feature

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.