Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staticchecks in vendor/k8s.io/client-go #95230

Merged
merged 1 commit into from Oct 15, 2020
Merged

Fix staticchecks in vendor/k8s.io/client-go #95230

merged 1 commit into from Oct 15, 2020

Conversation

Git-Jiro
Copy link
Contributor

@Git-Jiro Git-Jiro commented Oct 1, 2020

What type of PR is this?
/kind cleanup

Which issue(s) this PR fixes:
Part of #92402
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Git-Jiro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 1, 2020
@rikatz
Copy link
Contributor

rikatz commented Oct 1, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2020
@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 1, 2020

/test pull-kubernetes-integration

@fedebongio
Copy link
Contributor

/assign @caesarxuchao
thank you!

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 3, 2020

@sttts please take a quick look at hack/.staticcheck_failures

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2020
@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 6, 2020

/retest

1 similar comment
@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 6, 2020

/retest

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 7, 2020

/cc @soltysh @sttts

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 9, 2020

/retest

@Git-Jiro
Copy link
Contributor Author

/uncc @soltysh @sttts
/cc @juanvallejo @yliaog

@k8s-ci-robot k8s-ci-robot requested review from juanvallejo and yliaog and removed request for soltysh and sttts October 13, 2020 17:22
@caesarxuchao
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@caesarxuchao
Copy link
Member

If you see this message before it's merged, can you squash the commits?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
soltysh
soltysh approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, Git-Jiro, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 297b021 into kubernetes:master Oct 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 15, 2020
@Git-Jiro Git-Jiro deleted the fix_vendor_client_go branch October 15, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@soltysh soltysh soltysh approved these changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@soltysh soltysh

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Git-Jiro @k8s-ci-robot @rikatz @fedebongio @caesarxuchao @soltysh