New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log dumping for GKE #95525
Fix log dumping for GKE #95525
Conversation
@tosi3k: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubernetes-bazel-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tosi3k, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-node-e2e |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Recent
log-dump.sh
change in #94762 has broken log dumping in GKE. According to the build log the log dumping process fails here becausemaster_names
variable is unbound. I traced the change and found out that the relevant part of bash was changed fromto
Because
log_dump_custom_get_instances
doesn'techo
anything for GKE, we end up with unboundmaster_names
variable. Initializing it to the empty array()
resolves this problem.Which issue(s) this PR fixes:
No issue is opened for that.
Special notes for your reviewer:
/sig scalability
/assign @wojtek-t @jkaniuk
Does this PR introduce a user-facing change?: