Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log dumping for GKE #95525

Merged
merged 1 commit into from Oct 13, 2020
Merged

Conversation

tosi3k
Copy link
Member

@tosi3k tosi3k commented Oct 13, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Recent log-dump.sh change in #94762 has broken log dumping in GKE. According to the build log the log dumping process fails here because master_names variable is unbound. I traced the change and found out that the relevant part of bash was changed from

local master_names
if [[ -n "${use_custom_instance_list}" ]]; then
    master_names=( $(log_dump_custom_get_instances master)
(...)
fi
(...)
if [[ "${#master_names[@]}" == 0 ]]; then
  echo "No masters found?"
  return
fi

to

local master_names
if [[ -n "${use_custom_instance_list}" ]]; then
  while IFS='' read -r line; do master_names+=("$line"); done < <(log_dump_custom_get_instances master)
(...)
fi
if [[ "${#master_names[@]}" == 0 ]]; then
  echo 'No masters found?'
  return
fi

Because log_dump_custom_get_instances doesn't echo anything for GKE, we end up with unbound master_names variable. Initializing it to the empty array () resolves this problem.

Which issue(s) this PR fixes:
No issue is opened for that.

Special notes for your reviewer:
/sig scalability
/assign @wojtek-t @jkaniuk

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 13, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2020
@k8s-ci-robot
Copy link
Contributor

@tosi3k: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 13, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 13, 2020
@tosi3k
Copy link
Member Author

tosi3k commented Oct 13, 2020

/test pull-kubernetes-bazel-test

@jkaniuk
Copy link
Contributor

jkaniuk commented Oct 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2020
@wojtek-t
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@tosi3k
Copy link
Member Author

tosi3k commented Oct 13, 2020

/test pull-kubernetes-node-e2e

@tosi3k
Copy link
Member Author

tosi3k commented Oct 13, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6c40e16 into kubernetes:master Oct 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 13, 2020
@tosi3k tosi3k deleted the master-log-dump-gke branch February 9, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants