Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter wording to describe pods using a pvc #95635

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Alter wording to describe pods using a pvc #95635

merged 2 commits into from
Oct 27, 2020

Conversation

RaunakShah
Copy link
Contributor

@RaunakShah RaunakShah commented Oct 16, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR changes the description for kubectl get pvc. Currently, kubectl describe pvc has a MountedBy field that lists the Pod that use a PVC - irrespective of whether the Pod is in the Running state or not:

ubuntu@10:~$ kubectl describe pod test-pod
Name:           test-pod
Namespace:      default
...
Status:         Pending
...
ubuntu@10:~$ kubectl describe pvc test-pvc
Name:          test-pvc
Namespace:     default
...
Mounted By:    test-pod
...

In this case, the PVC is attached to a node but is not mounted.

This PR changes the wording of Mounted By to Used By.

Also removing an unnecessary function call + array copy.
https://kubernetes.slack.com/archives/C09QZFCE5/p1602026529166500
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Alter wording to describe pods using a pvc

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @RaunakShah. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2020
@dims
Copy link
Member

dims commented Oct 22, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2020
@dims
Copy link
Member

dims commented Oct 22, 2020

/assign @seans3 @deads2k

soltysh
soltysh approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
@RaunakShah you'll need to fix gofmt, though

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@RaunakShah
Copy link
Contributor Author

@soltysh done! I see that the bazel test is still failing on a kubectl describe pvc test.
But the errors are:

        describe_test.go:1641: expected to find "\nDataSource:\n  Kind:      PersistentVolumeClaim\n  Name:      srcpvc" in output: "Name:          bar\nNamespace:     foo\nStorageClass:  gold\nStatus:        \nVolume:        volume10\nLabels:        <none>\nAnnotations:   <none>\nFinalizers:    []\nCapacity:      0\nAccess Modes:  \nDataSource:\n  Kind:   PersistentVolumeClaim\n  Name:   srcpvc\nUsed By:  <none>\nEvents:   <none>\n"

and

        describe_test.go:1641: expected to find "\nDataSource:\n  Kind:      PersistentVolumeClaim\n  Name:      srcpvc" in output: "Name:          bar\nNamespace:     foo\nStorageClass:  gold\nStatus:        \nVolume:        volume10\nLabels:        <none>\nAnnotations:   <none>\nFinalizers:    []\nCapacity:      0\nAccess Modes:  \nDataSource:\n  Kind:   PersistentVolumeClaim\n  Name:   srcpvc\nUsed By:  <none>\nEvents:   <none>\n"

Which seems like a test issue?

@dims
Copy link
Member

dims commented Oct 23, 2020

/test pull-kubernetes-bazel-build

@dims
Copy link
Member

dims commented Oct 23, 2020

/test pull-kubernetes-bazel-test

soltysh
soltysh approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 23, 2020
@RaunakShah
Copy link
Contributor Author

RaunakShah commented Oct 23, 2020 •
edited

The bazel test looks like an issue with whitespaces? https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/describe/describe_test.go#L1604

Would be happy to fix it if that's the case..

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

11 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@soltysh
Copy link
Contributor

soltysh commented Oct 25, 2020

/hold
/lgtm cancel
the failure is real you need to fix it.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 25, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2020
@RaunakShah
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@RaunakShah
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@RaunakShah
Copy link
Contributor Author

@soltysh fixed the test case here too. Can you take another look?

@dims
Copy link
Member

dims commented Oct 27, 2020

looks good now the tests pass!

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2c58def into kubernetes:master Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@soltysh soltysh

@seans3 seans3

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@RaunakShah @k8s-ci-robot @dims @soltysh @fejta-bot @seans3 @deads2k