New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deflake PostFilter integration test #95807
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
Huang-Wei:postfilter-int-test-flake
Oct 23, 2020
Merged
Deflake PostFilter integration test #95807
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
Huang-Wei:postfilter-int-test-flake
Oct 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Denotes a PR that doesn't merit a release note.
kind/flake
Categorizes issue or PR as related to a flaky test.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Oct 22, 2020
/triage accepted |
k8s-ci-robot
added
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Oct 22, 2020
k8s-ci-robot
added
area/test
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
labels
Oct 22, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 22, 2020
/retest |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/test
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/flake
Categorizes issue or PR as related to a flaky test.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
release-note-none
Denotes a PR that doesn't merit a release note.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
/sig scheduling
What this PR does / why we need it:
The scheduler runs each Filter plugin among N nodes, in a parallel manner. So if we want to verify how many times the Filter plugin has been called, it's mandatory to ensure the counter is accessed atomically.
Which issue(s) this PR fixes:
Fixes #95700 #93782
Special notes for your reviewer:
Does this PR introduce a user-facing change?: