Fix bug in JSON path parser where an error occurs when a range is empty #95933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/api-machinery
|
/retest |
|
/assign @caesarxuchao |
k8s-ci-robot
added
triage/accepted
brianpursley
force-pushed
the
kubernetes-95882
branch
from
1d04342
to
10634c6
Compare
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, caesarxuchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@brianpursley can you make a cherry-pick to 1.19? Thanks. |
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 17, 2020
…#95933-upstream-release-1.19 Automated cherry pick of #95933: Fix bug in JSON path parser where an error occurs when a
liggitt
added
the
kind/regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix bug in JSON path parser where an error occurs when a range is empty.
The problem was that if the range contained no results, the position of the parser loop was not advanced to the end node, so when it reached the end node in the loop it seemed like there was no open range.
The fix is to make sure even if there are not results in the range, that it still advances to the end node as if it had processed something.
(BTW, this whole file seems sort of fragile and hard to conceptualize due to all the counters that are used across functions. Seems like there should be some opportunity to improve this, but that is for another time)
Which issue(s) this PR fixes:
Fixes #95882
Special notes for your reviewer:
This probably needs to be cherry-picked back to 1.19, where the problem was introduced.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: