Cleanup non-namespaced objects in e2e test during interrupts

[chrishenzie]

/sig storage

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes an issue where if this e2e test is interrupted, only the namespace gets cleaned up. Non-namespaced objects like StorageClasses are not cleaned up.

Which issue(s) this PR fixes:

Fixes #96022

Special notes for your reviewer:

The test framework has an AddAfterEach() block that allows us to handle this test cleanup logic.

Since we are handling the test cleanup in an AfterEach() step, I figured it was intuitive to handle the equivalent test setup in a BeforeEach() step. I split this into two parts. One that asserts things before the test framework is created (which creates a namespace), and one that sets up everything else after. These BeforeEach() blocks run sequentially before every It() block.

Does this PR introduce a user-facing change?:

NONE

@msau42

[k8s-ci-robot]

@chrishenzie: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @chrishenzie. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msau42]

/ok-to-test
/assign @gnufied
I thought we already did this?

Edit: nm I spoke too soon, this is adding it just to the testsuite

[msau42]

Do you know what the difference is between AddAfterEach and ginkgo.AfterEach?

[chrishenzie]

AddAfterEach appends a function to execute as part of the framework's AfterEach, which is registered with ginkgo via ginkgo.AfterEach:

kubernetes/test/e2e/framework/framework.go

Line 175 in 7bf9b0a

ginkgo.AfterEach(f.AfterEach)

I expected I could replace this with a call to ginkgo.AfterEach and see it work, but when I tested it, it didn't run.

[msau42]

That's unexpected. Most of our other tests do not use AddAfterEach. It may be worth following up with sig-testing on this.

[msau42]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishenzie, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/storage/OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[msau42]

/lgtm