Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change bucket for apiserver_request_filter_duration_seconds metric #96047

Merged
merged 1 commit into from Oct 30, 2020
Merged

Change bucket for apiserver_request_filter_duration_seconds metric #96047

merged 1 commit into from Oct 30, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Oct 30, 2020 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:
Change the 0.0s bucket to 0.0001s for apiserver_request_filter_duration_seconds metric

Does this PR introduce a user-facing change?:
-->

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 30, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Oct 30, 2020

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 30, 2020
@tkashem tkashem changed the title change bucket from 0.0s to 0.0001s Change bucket from 0.0s to 0.0001s Oct 30, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Oct 30, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 30, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Oct 30, 2020

/cc @MikeSpreitzer

@tkashem
Copy link
Contributor Author

tkashem commented Oct 30, 2020

/retest

@tkashem tkashem changed the title Change bucket from 0.0s to 0.0001s Change bucket from 0.0s to 0.0001s for apiserver_request_filter_duration_seconds metric Oct 30, 2020
@tkashem tkashem changed the title Change bucket from 0.0s to 0.0001s for apiserver_request_filter_duration_seconds metric Change bucket for apiserver_request_filter_duration_seconds metric Oct 30, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Oct 30, 2020

This is a followup PR for a suggestion from @wojtek-t - https://github.com/kubernetes/kubernetes/pull/95207/files#r514912865

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tkashem, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7bf9b0a into kubernetes:master Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@MikeSpreitzer MikeSpreitzer Awaiting requested review from MikeSpreitzer

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkashem @wojtek-t @k8s-ci-robot