Make nodeaffinity parsing functions return field.Error

[alculquicondor]

The k8s.io/component-helpers/scheduling/corev1/nodeaffinity constructors return a parsed version of the input types. While doing that, they detect parsing errors that can be aggregated in higher level validators, such as ValidateNodeAffinityArgs.

For a proper implementation, all the returned errors should be of the type field.Error.

/sig scheduling

[ahg-g]

/help
/good-first-issue
/triage accepted

[lingsamuel]

These constructors raise errors mainly from labels.Requirement, which is a quite generic function. It's hard to change a fmt.Errorf to field.Error.
I noticed ValidateNodeSelectorRequirement in pkg/apis/core/validation/validation.go has similar logic compare with labels.NewRequirement, so write new validate functions instead change this constructor maybe a better choice?

[alculquicondor]

/remove-good-first-issue

This is actually not trivial :(

[alculquicondor]

so write new validate functions instead change this constructor maybe a better choice?

No, the whole point is to avoid code duplication. We can change all the functions that are called to return field.Error or an aggregation of them. But we have to keep the same function signatures.

[lingsamuel]

Then I guess this will be a big refactoring task, not just sig/scheduling.

[alculquicondor]

It's not too big, but indeed beyond scheduling OWNERship

/sig api-machinery

[lingsamuel]

I am handling other funcs in pkg/scheduler/apis/config/validation/validation_pluginargs.go