New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid creating clusters with more than 100 nodes without vpc-native #96418
Forbid creating clusters with more than 100 nodes without vpc-native #96418
Conversation
@marseel: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @marseel! |
Hi @marseel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @wojtek-t |
1 similar comment
/assign @wojtek-t |
cluster/gce/config-default.sh
Outdated
@@ -354,6 +354,9 @@ elif [[ -n "${MAX_PODS_PER_NODE:-}" ]]; then | |||
# Should not have MAX_PODS_PER_NODE set for route-based clusters. | |||
echo -e "${color_red:-}Cannot set MAX_PODS_PER_NODE for route-based projects for ${PROJECT}." >&2 | |||
exit 1 | |||
elif [[ "$(get-num-nodes)" -gt 100 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you change that int:
if [ "${ENABLE_IP_ALIASES}" = true ]; then
...
else
if [[ -n "${MAX_PODS_PER_NODE:-}" ]]; then
..
fi
if [[ <your condition>]]; then
..
fi
fi
It's easier to follow that those conditions are basically not really connected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, done.
7321667
to
560397e
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marseel, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
560397e
to
6e598a9
Compare
I've only rebased this branch, because test jobs were exiting with error "merge: 560397e0600a7ef36995b6c097e8ca5d1c54850a - not something we can merge" |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently GCE cannot support large clusters without vpc-native. Therefore this PR is adding check to make sure nobody is trying to create such cluster.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig scalability
/cc @mborsz
/cc @wojtek-t