Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug that DefaultPreemption plugin is disabled when using scheduler policy #96439

Merged
merged 1 commit into from Nov 11, 2020
Merged

Fix a bug that DefaultPreemption plugin is disabled when using scheduler policy #96439

merged 1 commit into from Nov 11, 2020

Conversation

Huang-Wei
Copy link
Member

What type of PR is this?

/kind bug
/sig scheduling

What this PR does / why we need it:

Fix a bug that DefaultPreemption plugin is disabled when using (legacy) scheduler policy.

Which issue(s) this PR fixes:

Fixes #96437

Special notes for your reviewer:

This bug exists in 1.19 as well. Fix needs to be back-ported.

Does this PR introduce a user-facing change?:

Fix a bug that DefaultPreemption plugin is disabled when using (legacy) scheduler policy.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 11, 2020
@Huang-Wei
Copy link
Member Author

/triage accepted
/priority critical-urgent
/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2020
@Huang-Wei
Copy link
Member Author

/retest

hex108
hex108 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@hex108 hex108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hex108, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Member

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit c376909 into kubernetes:master Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 11, 2020
@Huang-Wei Huang-Wei mentioned this pull request Nov 11, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 17, 2020
@k8s-ci-robot
Merge pull request #96472 from Huang-Wei/automated-cherry-pick-of-#96…
dd8776f 
…439-upstream-release-1.19

Automated cherry pick of #96439: Fix a bug that DefaultPreemption plugin is disabled when
@github-actions github-actions bot mentioned this pull request Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 hex108 approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

DefaultPreemption plugin is not created when Policy API is used?
4 participants
@Huang-Wei @k8s-ci-robot @alculquicondor @hex108