Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change GetFullQualifiedPluginNameForVolume to distinuish different drivers #96477

Merged
merged 1 commit into from Nov 17, 2020
Merged

change GetFullQualifiedPluginNameForVolume to distinuish different drivers #96477

merged 1 commit into from Nov 17, 2020

Conversation

mattcary
Copy link
Contributor

/kind bug

Which issue(s) this PR fixes:

Backports #95892

More precisely, this backports part of that fix, to clarify CSI driver names in metrics, and does not backpart the larger metrics changes of that PR.

Metric names for CSI and flexvolume drivers will include the driver name as well as the CSI plugin name.

@JornShen @mattcary
change GetFullQualifiedPluginNameForVolume to distinuish different dr…
c7b1e3d 
…ivers

Change-Id: Iaeafa67215565f7f4906fc2b683c8a231bee8e90
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2020
@mattcary
Copy link
Contributor Author

/assign msau42

@msau42
Copy link
Member

msau42 commented Nov 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@mattcary mattcary mentioned this pull request Nov 11, 2020
Merged
@mattcary
Copy link
Contributor Author

@kubernetes/release-managers

This is good to cherry-pick, thanks!

@feiskyer
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 17, 2020
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 377906d into kubernetes:release-1.19 Nov 17, 2020
yuga711 pushed a commit to yuga711/kubernetes that referenced this pull request Dec 3, 2020
@JornShen @mattcary
change GetFullQualifiedPluginNameForVolume to distinuish different dr…
f979aa3 
…ivers

(Merged upstream in 1.19 as kubernetes#96477)

Bug: 172255810
Change-Id: Iefc0ad09fd82db35ac3f745e6c7358ceb83ff422
(cherry picked from commit 32bc48488074c9a0d6f49dfb1f500e3385e33d1c)
@pacoxu pacoxu mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattcary @msau42 @k8s-ci-robot @feiskyer @JornShen