Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ingress conformance test for finalizers #96742

Merged
merged 1 commit into from Nov 30, 2020
Merged

Update ingress conformance test for finalizers #96742

merged 1 commit into from Nov 30, 2020

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Nov 20, 2020 •
edited by liggitt

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Updates Ingress Conformance tests to check for deletionTimestamp instead of 404 due to finalizers.

This will need to be cherry-picked to release-1.19

Resolves an issue running Ingress conformance tests on clusters which use finalizers on Ingress objects to manage releasing load balancer resources

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 20, 2020
@spencerhance
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Nov 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2020
@liggitt
Copy link
Member

liggitt commented Nov 24, 2020

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 24, 2020
@spencerhance spencerhance force-pushed the ingress-conformance-test branch 2 times, most recently from cd6ced0 to b7c701a Compare November 25, 2020 19:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2020
@liggitt
Copy link
Member

liggitt commented Nov 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2020
@bowei
Copy link
Member

bowei commented Nov 25, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@spencerhance
Copy link
Contributor Author

/retest

@spencerhance
Copy link
Contributor Author

@liggitt looks like it just needs a milestone now

@liggitt
Copy link
Member

liggitt commented Nov 26, 2020

@kubernetes/sig-release - would like a ruling on this for 1.20 vs 1.20.1. This should be merged and picked to 1.19 as well.

Without this PR, this conformance test (added in 1.19) fails on clusters that use finalizers on ingress objects to manage releasing load balancer resources.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 26, 2020
hasheddan
hasheddan approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, hasheddan, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt mentioned this pull request Nov 30, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Nov 30, 2020

Thanks. Picked to 1.19 in #96953

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e306323 into kubernetes:master Nov 30, 2020
@spencerhance spencerhance deleted the ingress-conformance-test branch November 30, 2020 20:14
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2020
@k8s-ci-robot
Merge pull request #96953 from liggitt/automated-cherry-pick-of-#9674…
47e1e56 
…2-upstream-release-1.19

Automated cherry pick of #96742: Update ingress conformance test for finalizers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@liggitt liggitt liggitt left review comments

@hasheddan hasheddan hasheddan approved these changes

@freehan freehan Awaiting requested review from freehan

@m1093782566 m1093782566 Awaiting requested review from m1093782566

Assignees

@bowei bowei

@liggitt liggitt

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spencerhance @k8s-ci-robot @liggitt @bowei @fejta-bot @hasheddan