Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment default behaviour of kubectl drain.GracePeriodSeconds #96812

Merged
merged 1 commit into from Jan 21, 2021
Merged

Comment default behaviour of kubectl drain.GracePeriodSeconds #96812

merged 1 commit into from Jan 21, 2021

Conversation

bboreham
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

It took me a while to spot this subtlety.

Which issue(s) this PR fixes:
Relates to kubernetes/kubectl#982

NONE

@bboreham
Comment default behaviour of GracePeriodSeconds
7c764c8 
It took me a while to spot this subtlety.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 23, 2020
@bboreham bboreham changed the title Comment default behaviour of GracePeriodSeconds Comment default behaviour of kubectl drain.GracePeriodSeconds Nov 23, 2020
@bboreham
Copy link
Contributor Author

/retest

@bboreham
Copy link
Contributor Author

/sig cli

evrardjp
evrardjp reviewed Nov 24, 2020
View reviewed changes
Copy link

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair.

@eddiezane
Copy link
Member

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 9, 2020
@eddiezane
Copy link
Member

/assign @soltysh @brianpursley

@brianpursley
Copy link
Member

/lgtm

This comment just documents the existing behavior. @soltysh wdyt about the wording? It seems OK to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
soltysh
soltysh approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bboreham, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit c2ac8c3 into kubernetes:master Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 21, 2021
@dougsland dougsland mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evrardjp evrardjp evrardjp left review comments

@soltysh soltysh soltysh approved these changes

@dims dims Awaiting requested review from dims

@dixudx dixudx Awaiting requested review from dixudx

Assignees

@soltysh soltysh

@brianpursley brianpursley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bboreham @eddiezane @brianpursley @k8s-ci-robot @soltysh @evrardjp