New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finetune container-runtime-endpoint option help text #96857
Finetune container-runtime-endpoint option help text #96857
Conversation
Signed-off-by: Jussi Nummelin <jussi.nummelin@gmail.com>
@jnummelin: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @jnummelin! |
Hi @jnummelin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jnummelin, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jussi Nummelin jussi.nummelin@gmail.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add a note to kubelet
container-runtime-endpoint
option to clearly indicate that in case of Docker being used the path points to dockershim socket created by kubelet itself. I'd guess I'm not the only one been banging their heads on this as I assumed from the flag description that I should give/var/run/docker.sock
in to this option.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: