Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index test: multi index check for empty list #96883

Merged
merged 1 commit into from Dec 16, 2020
Merged

fix index test: multi index check for empty list #96883

merged 1 commit into from Dec 16, 2020

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Nov 26, 2020 •
edited

What type of PR is this?
/kind cleanup
/sig testing

What this PR does / why we need it:
Per #96862 , empty expected set here will always success no matter what index is found.

Which issue(s) this PR fixes:

Fixes #96862

Special notes for your reviewer:
size/len check is for empty list.

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 26, 2020
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 26, 2020
@pacoxu pacoxu mentioned this pull request Nov 26, 2020
Closed
@pacoxu
Copy link
Member Author

pacoxu commented Nov 26, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 26, 2020
@pacoxu

This comment has been minimized.

Sign in to view
1 similar comment
@pacoxu

This comment has been minimized.

Sign in to view
@fedebongio
Copy link
Contributor

/assign @yliaog
@pacoxu please don't remove the triage labels, is the way we find them during our triage.
Thanks!

@pacoxu
Copy link
Member Author

pacoxu commented Dec 1, 2020

@fedebongio Thanks.

Is there a way to remove the label triage/accepted?

@fedebongio
Copy link
Contributor

@pacoxu yes, you would do ''''/remove-triage accepted'''''
Although, we triaged it and assigned it to @yliaog for revision, so in this case we are good, no need to change.

thanks!
Fede

@yliaog
Copy link
Contributor

yliaog commented Dec 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Dec 3, 2020

@fedebongio thanks

@pacoxu
Copy link
Member Author

pacoxu commented Dec 9, 2020

per #96862 (comment)

/sig api-machinery
/remove-sig testing

@k8s-ci-robot k8s-ci-robot removed the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Dec 9, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Dec 12, 2020

/assign @liggitt

@pacoxu
fix index test: multi index check for empty list
ae6360f 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Dec 16, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Dec 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 46d481b into kubernetes:master Dec 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 16, 2020
@pacoxu pacoxu deleted the fix/96862 branch June 23, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@liggitt liggitt

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

this test is wierd to set expected twice, and the last set is not correct
5 participants
@pacoxu @fedebongio @yliaog @liggitt @k8s-ci-robot