Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Enable some [LinuxOnly] tests for Windows Containerd #97045

Merged
merged 1 commit into from
Oct 7, 2021
Merged

tests: Enable some [LinuxOnly] tests for Windows Containerd #97045

merged 1 commit into from
Oct 7, 2021

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/sig windows
/sig testing

What this PR does / why we need it:

Windows Containerd has more features than Windows Docker. One of them is single file mappings, allowing us to also map individual files into containers, not just folders.

This will set the tag [Excluded:WindowsDocker] for those tests instead of [LinuxOnly].

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 3, 2020
@claudiubelu
Copy link
Contributor Author

/retest

@immuzz immuzz added this to In Progress (v1.21) in SIG-Windows Dec 17, 2020
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

1 similar comment
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@marosset
Copy link
Contributor

@claudiubelu It looks like this PR needs some updates to the build files.
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 14, 2021
@claudiubelu claudiubelu force-pushed the tests-windows-containerd-enabled branch from 1a53681 to 02f9bc6 Compare January 15, 2021 15:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2021
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@dims
Copy link
Member

dims commented Feb 13, 2021

/kind cleanup
/assign @johnbelamaric @spiffxp

John, Aaron, the changes here looks good to me. However my question is ... was this already discussed / ok-ed by you all? (adding a new tag)

@claudiubelu claudiubelu force-pushed the tests-windows-containerd-enabled branch 2 times, most recently from a38908a to 45e3059 Compare August 16, 2021 12:51
@claudiubelu @marosset
tests: Enable some [LinuxOnly] tests for Windows Containerd
91c095a 
Windows Containerd has more features than Windows Docker. One of them is single file
mappings, allowing us to also map individual files into containers, not just folders.

This will set the tag [Excluded:WindowsDocker] for those tests instead of [LinuxOnly].

Co-authored-by: Mark Rossetti <marosset@microsoft.com>
@claudiubelu claudiubelu force-pushed the tests-windows-containerd-enabled branch from 45e3059 to 91c095a Compare August 16, 2021 14:43
@claudiubelu
Copy link
Contributor Author

/retest

5 similar comments
@claudiubelu
Copy link
Contributor Author

/retest

@claudiubelu
Copy link
Contributor Author

/retest

@marosset
Copy link
Contributor

/retest

@claudiubelu
Copy link
Contributor Author

/retest

@marosset
Copy link
Contributor

/retest

@marosset
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial

1 similar comment
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial

@k8s-ci-robot
Copy link
Contributor

@claudiubelu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial 91c095a link false /test pull-kubernetes-node-kubelet-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SergeyKanzhelev
Copy link
Member

/skip

serial is irrelevant here

@spiffxp
Copy link
Member

spiffxp commented Oct 4, 2021

I'd like to see an open issue to remove this tag in v1.24, and the description for the tag updated to link to said issue: kubernetes/community#5355 (review)

Once the kubernetes/community PR merges I'm fine letting this merge

@claudiubelu
Copy link
Contributor Author

I'd like to see an open issue to remove this tag in v1.24, and the description for the tag updated to link to said issue: kubernetes/community#5355 (review)

Once the kubernetes/community PR merges I'm fine letting this merge

Created issue: kubernetes/community#6123

spiffxp
spiffxp approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Just approved the community PR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, pacoxu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit c20ff98 into kubernetes:master Oct 7, 2021
conformance-definition automation moved this from PRs Needing Review to Done Oct 7, 2021
SIG-Windows automation moved this from Reviewed - Needs Approval From Other SIGs to Done (v1.23) Oct 7, 2021
SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 7, 2021
This was referenced Oct 7, 2021
Merged
Merged
@claudiubelu claudiubelu mentioned this pull request Mar 22, 2022
Merged
@claudiubelu claudiubelu mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@marosset marosset marosset left review comments

@spiffxp spiffxp spiffxp approved these changes

@pacoxu pacoxu pacoxu approved these changes

@odinuge odinuge Awaiting requested review from odinuge

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@spiffxp spiffxp

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
PRs Waiting on Author
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG-Windows
  
Done (v1.23)
conformance-definition
  
Done
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@claudiubelu @marosset @dims @SergeyKanzhelev @k8s-ci-robot @spiffxp @pacoxu @johnbelamaric