New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the test VolumeHosts type into one per interface #97354
Split the test VolumeHosts type into one per interface #97354
Conversation
@chrishenzie: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
856f29f
to
60797f8
Compare
/sig testing |
fakeVolumeHost previously implemented both the KubeletVolumeHost and AttachDetachVolumeHost interfaces. This design makes it difficult to test the CSIAttacher since it behaves differently depending on what type of VolumeHost is supplied.
60797f8
to
9d8f994
Compare
/retest |
@chrishenzie: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
fakeVolumeHost
previously implemented both theKubeletVolumeHost
andAttachDetachVolumeHost
interfaces. This design makes it difficult to fully test thecsiAttacher
andcsiPlugin
because their behavior depends on which interface theVolumeHost
implements.kubernetes/pkg/volume/csi/csi_plugin.go
Lines 192 to 216 in c4aca30
This is a prerequisite cleanup step for #64429.
Which issue(s) this PR fixes:
See above, this does not fix a particular issue but is a cleanup step prior to tackling the issue.
Special notes for your reviewer:
I would suggest looking at the new
VolumeHost
test types as a starting point, which can provide context on the other changes in the commit.Does this PR introduce a user-facing change?:
/sig storage
/assign @Jiawei0227
/assign @jingxu97
@msau42
@saad-ali