New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify LeaderElectionConfiguration .ResourceNamespace comment #97361
Conversation
Welcome @h4ghhh! |
Hi @h4ghhh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@h4ghhh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@mysunshine92: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/kind cleanup /sig api-machinery |
/release-note-none |
/assign @caesarxuchao |
/lgtm |
/assign @lavalamp this directory actually requires an api-approver to approve, https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/config/OWNERS |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h4ghhh, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LeaderElectionConfiguration struct:
ResourceNamespace has a wrong comment.