Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix static check for vendor/k8s.io/apiserver/pkg/storage/etcd3/ #97786

Merged
merged 1 commit into from Jan 12, 2021
Merged

fix static check for vendor/k8s.io/apiserver/pkg/storage/etcd3/ #97786

merged 1 commit into from Jan 12, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 7, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
static check on vendor/k8s.io/apiserver/pkg/storage/etcd3/ part of #92402

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 7, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 7, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@dims
Copy link
Member

dims commented Jan 7, 2021

/approve (for hack/)

@fedebongio
Copy link
Contributor

/assign @jingyih
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 7, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 8, 2021

/assign @lavalamp

@jingyih
Copy link
Contributor

jingyih commented Jan 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021
@jingyih
Copy link
Contributor

jingyih commented Jan 12, 2021

/assign @wojtek-t
for storage approval

@wojtek-t
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 12, 2021

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit ef3337a into kubernetes:master Jan 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 12, 2021
@pacoxu pacoxu deleted the staticcheck/apiserver-storage branch June 23, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@lavalamp lavalamp

@wojtek-t wojtek-t

@jingyih jingyih

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pacoxu @dims @fedebongio @jingyih @wojtek-t @k8s-ci-robot @lavalamp