Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata concealment: remove the legacy endpoints from the check #97789

Merged
merged 1 commit into from Jan 23, 2021
Merged

metadata concealment: remove the legacy endpoints from the check #97789

merged 1 commit into from Jan 23, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 7, 2021

What type of PR is this?
/kind cleanup
/sig auth
/sig cloud-provider
/provider gcp
/sig testing

What this PR does / why we need it:

I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches.
From @spiffxp description in #94791.

v1beta1 server and v0.1 metadata server endpoints were deprecated on September 30, 2020 and are in the process of being shutdown. Ensure that you update all requests to use v1. For more information, see Transitioning to the v1 metadata server endpoint.

Which issue(s) this PR fixes:
Fixes #94791

Special notes for your reviewer:
references:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2021
@pacoxu pacoxu mentioned this pull request Jan 7, 2021
Closed
@mikedanese mikedanese self-assigned this Jan 7, 2021
@mikedanese
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2021
@mikedanese mikedanese added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2021
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 7, 2021

WDYT @dekkagaijin @ixdy @idealhack since you were involved with the earlier PRs
@kubernetes/sig-auth-misc

@pacoxu pacoxu mentioned this pull request Jan 20, 2021
Closed
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 20, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@dekkagaijin
Copy link
Contributor

/lgtm
/approve

@dekkagaijin
Copy link
Contributor

/retest

@liggitt
Copy link
Member

liggitt commented Jan 20, 2021

this is just changing the code in the test image. when/how does the test image get rebuilt and the version used in kube e2e's bumped to actually be effective?

spiffxp
spiffxp suggested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to change VERSION file

@spiffxp
Copy link
Member

spiffxp commented Jan 20, 2021

/hold
for requested changes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 20, 2021

/approve cancel

@spiffxp
Copy link
Member

spiffxp commented Jan 20, 2021

@liggitt
Next steps would be:

@spiffxp
Copy link
Member

spiffxp commented Jan 20, 2021

We are in the midst of migrating away from gcr.io/kubernetes-e2e-test-images toward k8s.gcr.io/e2e-test-images (ref: #96770)

@pacoxu
metadata concealment: remove the legacy endpoints from the check, bum…
5d6c41c 
…p the image version

Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 21, 2021

Thanks, @spiffxp for reviewing.
Version is changed, PTAL again.

@pacoxu pacoxu requested a review from spiffxp January 22, 2021 03:39
@pacoxu
Copy link
Member Author

pacoxu commented Jan 22, 2021

/hold
for requested changes

can I /hold cancel now？

@pacoxu
Copy link
Member Author

pacoxu commented Jan 23, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2021
spiffxp
spiffxp approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dekkagaijin, mikedanese, pacoxu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6760796 into kubernetes:master Jan 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 23, 2021
This was referenced Jan 24, 2021
Merged
Merged
Merged
@pacoxu pacoxu deleted the fix/gce-depre-version branch June 23, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@listx listx Awaiting requested review from listx

Assignees

@spiffxp spiffxp

@dekkagaijin dekkagaijin

@destijl destijl

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Metadata Concealment test exercises endpoints due to be removed 2020-09-30
7 participants
@pacoxu @mikedanese @destijl @dekkagaijin @liggitt @spiffxp @k8s-ci-robot