Refactor: rewrite Merge method to address readability and efficiency

[chendave]

Signed-off-by: Dave Chen dave.chen@arm.com

@ahg-g @lixiang233 I came across this line of code today, and I do think this line of code is a legacy nit, the status code has been set in the below snippet of code, but in the loop it was set for each plugin, consider the case that status map hold the status for each of plugin, this kind of instruction is not effective and unnecessary.

kubernetes/pkg/scheduler/framework/interface.go

Lines 202 to 208 in c5cc25d

	if finalStatus.err != nil {
	finalStatus.code = Error
	} else if hasUnschedulableAndUnresolvable {
	finalStatus.code = UnschedulableAndUnresolvable
	} else if hasUnschedulable {
	finalStatus.code = Unschedulable
	}

For the sake of other status code might be added in the future, we can tweak the code a little bit.

@ahg-g what do you think?

What type of PR is this?

Add one of the following kinds:
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@chendave: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

I don't think this PR is increasing readability.

However, I do think this function is hard to read. I would reconsider if you can come up with an alternate rewrite of the function that is more readable.

[ahg-g]

right, this doesn't move the readability needle.

[chendave]

/hold

[chendave]

/hold cancel

[chendave]

@alculquicondor How about this version?

[chendave]

/retest

[alculquicondor]

Don't forget to update title and description

[chendave]

/retitle "Refactor: rewrite Merge method to address readability and efficiency"

[chendave]

/retitle Refactor: rewrite Merge method to address readability and efficiency

[chendave]

/retest

[alculquicondor]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, chendave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/lgtm