Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using bazel for unit tests #97921

Closed
liggitt opened this issue Jan 11, 2021 · 6 comments
Closed

Stop using bazel for unit tests #97921

liggitt opened this issue Jan 11, 2021 · 6 comments
Assignees
@BenTheElder
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
sig-testing issues
Milestone
v1.21

Comments

@liggitt
Copy link
Member

liggitt commented Jan 11, 2021

What would you like to be added:

Switch the unit test job to use go test (e.g. make test) instead of using bazel.

Why is this needed:

The unit test job is one of the few remaining places we use bazel (#88553)
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 11, 2021
@liggitt
Copy link
Member Author

liggitt commented Jan 11, 2021

cc @BenTheElder

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 11, 2021
@liggitt
Copy link
Member Author

liggitt commented Jan 11, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2021
@liggitt liggitt mentioned this issue Jan 21, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Jan 21, 2021

/triage accepted
/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 21, 2021
@spiffxp spiffxp mentioned this issue Feb 4, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Feb 4, 2021

/milestone v1.21
Focus on doing this for the v1.21 tests first

Depending on how much test-gap/fix work this uncovers, decide whether to backport or age-out for supported release branches

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 4, 2021
@spiffxp spiffxp added this to Backlog in sig-testing issues Feb 9, 2021
@BenTheElder BenTheElder moved this from Backlog to Done in sig-testing issues Mar 4, 2021
@BenTheElder
Copy link
Member

This is done. See: kubernetes/enhancements#2420

@BenTheElder
Copy link
Member

context on what all actually had to happen: kubernetes/enhancements#2420 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
sig-testing issues
  
Done
Milestone
v1.21
Development

No branches or pull requests
5 participants
@spiffxp @BenTheElder @liggitt @k8s-ci-robot and others