Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint errors for k8s.io/cli-runtime/pkg/genericclioptions/ #98003

Merged
merged 1 commit into from Jan 21, 2021

Conversation

lauchokyip
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Fix golint errors for k8s.io/cli-runtime/pkg/genericclioptions/

Errors from golint:
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags_fake.go:23:1: comment on exported function NewSimpleFakeResourceFinder should be of the form "NewSimpleFakeResourceFinder ..."
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:55:1: exported method ResourceBuilderFlags.WithFile should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:65:1: exported method ResourceBuilderFlags.WithLabelSelector should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:70:1: exported method ResourceBuilderFlags.WithFieldSelector should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:75:1: exported method ResourceBuilderFlags.WithAllNamespaces should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:80:1: exported method ResourceBuilderFlags.WithAll should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:85:1: exported method ResourceBuilderFlags.WithLocal should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:90:1: exported method ResourceBuilderFlags.WithScheme should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:95:1: exported method ResourceBuilderFlags.WithLatest should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/builder_flags.go:100:1: exported method ResourceBuilderFlags.StopOnError should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/client_config.go:26:2: exported var ErrEmptyConfig should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:30:6: exported type TestConfigFlags should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:36:1: exported method TestConfigFlags.ToRawKubeConfigLoader should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:43:1: exported method TestConfigFlags.ToRESTConfig should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:47:1: exported method TestConfigFlags.ToDiscoveryClient should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:51:1: exported method TestConfigFlags.ToRESTMapper should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:63:1: exported method TestConfigFlags.WithClientConfig should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:68:1: exported method TestConfigFlags.WithRESTMapper should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:73:1: exported method TestConfigFlags.WithDiscoveryClient should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:78:1: exported method TestConfigFlags.WithNamespace should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go:89:1: exported function NewTestConfigFlags should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/filename_flags.go:28:1: comment on exported type FileNameFlags should be of the form "FileNameFlags ..." (with optional leading article)
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/filename_flags.go:39:1: exported method FileNameFlags.ToOptions should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/filename_flags.go:59:1: exported method FileNameFlags.AddFlags should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/jsonpath_flags.go:49:1: exported method JSONPathPrintFlags.AllowedFormats should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/jsonpath_flags.go:92:27: error strings should not be capitalized or end with punctuation or a newline
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/jsonpath_flags.go:100:26: error strings should not be capitalized or end with punctuation or a newline
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/json_yaml_flags.go:27:1: exported method JSONYamlPrintFlags.AllowedFormats should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/kube_template_flags.go:36:1: exported method KubeTemplatePrintFlags.AllowedFormats should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/kube_template_flags.go:43:1: exported method KubeTemplatePrintFlags.ToPrinter should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/name_flags.go:38:1: exported method NamePrintFlags.Complete should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/name_flags.go:43:1: exported method NamePrintFlags.AllowedFormats should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:30:6: exported type NoCompatiblePrinterError should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:46:1: exported function IsNoCompatiblePrinterError should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:72:1: exported method PrintFlags.Complete should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:76:1: exported method PrintFlags.AllowedFormats should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:84:1: exported method PrintFlags.ToPrinter should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:121:1: exported method PrintFlags.AddFlags should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/print_flags.go:148:1: exported function NewPrintFlags should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/record_flags.go:77:1: exported method RecordFlags.CompleteWithChangeCause should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/template_flags.go:50:1: exported method GoTemplatePrintFlags.AllowedFormats should have comment or be unexported
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/template_flags.go:93:27: error strings should not be capitalized or end with punctuation or a newline
staging/src/k8s.io/cli-runtime/pkg/genericclioptions/template_flags.go:101:26: error strings should not be capitalized or end with punctuation or a newline

Which issue(s) this PR fixes:

Part of #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lauchokyip. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2021
@krmayankk
Copy link

/ok-to-test
/cleanup

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2021
@lauchokyip
Copy link
Member Author

/assign @soltysh

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/lgtm
/approve
For future, I'd probably ignore commenting test files 😉

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lauchokyip, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7eef3ed into kubernetes:master Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants