Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove weird pause args from this networking.go, that break the perio… #98124

Merged
merged 1 commit into from Jan 17, 2021
Merged

remove weird pause args from this networking.go, that break the perio… #98124

merged 1 commit into from Jan 17, 2021

Conversation

jayunit100
Copy link
Member

Quick fix to #98117

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2021
@jayunit100
Copy link
Member Author

@knabben

@knabben
Copy link
Member

knabben commented Jan 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2021
@aojea
Copy link
Member

aojea commented Jan 17, 2021

/kind failing-test
/sig network
/sig testing
/lgtm
/assign @andrewsykim @BenTheElder

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 17, 2021
hasheddan
hasheddan approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@jayunit100
Copy link
Member Author

/test pull-kubernetes-e2e-ubuntu-gce-network-policies

@jayunit100
Copy link
Member Author

/retest

@cblecker
Copy link
Member

/approve
/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 17, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 17, 2021
@cblecker
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, hasheddan, jayunit100

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit d72c056 into kubernetes:master Jan 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 17, 2021
BenTheElder
BenTheElder reviewed Jan 18, 2021
View reviewed changes
test/e2e/network/networking.go
@@ -52,6 +52,7 @@ func checkConnectivityToHost(f *framework.Framework, nodeName, podName, host str

pod := e2epod.NewAgnhostPod(f.Namespace.Name, podName, nil, nil, nil)
pod.Spec.Containers[0].Command = command
pod.Spec.Containers[0].Args = nil // otherwise 'pause` is magically an argument to nc, which causes all hell to break loose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: edited comment to make more sense:

It seems like the correct layering here is to do s/command/args/ in general, the command here should likely be passed as the args (docker CMD) instead of command (ENTRYPOINT), leaving room for entrypoint hijinks later.

This also avoids the args = []string{"pause} defaulting that seems to be WAI when the CMD isn't specified.

Aside: the naming of these things continues to be really unfortunate and the inconsistency doesn't help 😞 . It's really ~ "ArgV" and "AppendedToArgV" :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just tried to urbandictionary WAI and couldnt figure out what it is :) ?

@aojea aojea mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@hasheddan hasheddan hasheddan approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aojea aojea Awaiting requested review from aojea

Assignees

@BenTheElder BenTheElder

@knabben knabben

@aojea aojea

@andrewsykim andrewsykim

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jayunit100 @knabben @aojea @cblecker @k8s-ci-robot @BenTheElder @hasheddan @andrewsykim