Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #465 in cloud provider azure: Cleanup subnet in frontend IP configs #98133

Merged
merged 1 commit into from Feb 18, 2021
Merged

Cherry pick #465 in cloud provider azure: Cleanup subnet in frontend IP configs #98133

merged 1 commit into from Feb 18, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jan 18, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:
Cleanup subnet in frontend IP configs to prevent huge subnet request bodies in some scenarios.
Ref: kubernetes-sigs/cloud-provider-azure#465

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cleanup subnet in frontend IP configs to prevent huge subnet request bodies in some scenarios.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority critical-urgent
/area provider/azure
/sig cloud-provider
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 18, 2021
@nilo19
Copy link
Member Author

nilo19 commented Jan 19, 2021

/retest

feiskyer
feiskyer approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@feiskyer
Copy link
Member

/assign @cheftako @andrewsykim
for cloud provider approve

@nilo19
Copy link
Member Author

nilo19 commented Jan 19, 2021

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jan 19, 2021

redirecting, I'm only in the approvers list for dep updates

/unassign
/assign andrewsykim cheftako

@k8s-ci-robot k8s-ci-robot assigned andrewsykim and cheftako and unassigned liggitt Jan 19, 2021
andrewsykim
andrewsykim reviewed Jan 19, 2021
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/azure/azure_backoff.go
@@ -183,11 +183,40 @@ func (az *Cloud) CreateOrUpdateSecurityGroup(sg network.SecurityGroup) error {
return rerr.Error()
}

func cleanupSubnetInFrontendIPConfigurations(lb *network.LoadBalancer) network.LoadBalancer {
if lb.LoadBalancerPropertiesFormat == nil || lb.FrontendIPConfigurations == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for checking if LoadBalancerPropertiesFormat is nil? I don't see it used below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lb.FrontendIPConfigurations is actually lb.LoadBalancerPropertiesFormat.FrontendIPConfigurations

@feiskyer
Copy link
Member

ping @andrewsykim. Could you help to approve this change?

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0a848a5 into kubernetes:master Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 18, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-465 branch February 19, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@feiskyer feiskyer feiskyer approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@feiskyer feiskyer

@cheftako cheftako

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @feiskyer @liggitt @cheftako @k8s-ci-robot @andrewsykim