Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: bump BASEIMAGE of kitten and nautilus to agnhost 2.26 #98188

Merged
merged 1 commit into from Jan 19, 2021
Merged

test images: bump BASEIMAGE of kitten and nautilus to agnhost 2.26 #98188

merged 1 commit into from Jan 19, 2021

Conversation

chewong
Copy link
Member

@chewong chewong commented Jan 19, 2021 •
edited

Signed-off-by: Ernest Wong chuwon@microsoft.com

What type of PR is this?

Bumping BASEIMAGE of kitten and nautilus from agnhost 2.25 to 2.26 because we didn't have the chance to finish building Windows version of agnhost before bumping it to 2.26.

/sig testing
/sig windows
/kind cleanup
/priority important-soon
/assign @claudiubelu

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

test images: bump BASEIMAGE of kitten and nautilus to agnhost 2.26
9af74a6 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2021
@chewong
Copy link
Member Author

chewong commented Jan 19, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

@chewong: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 19, 2021
@claudiubelu
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, claudiubelu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@chewong
Copy link
Member Author

chewong commented Jan 19, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 22dabe6 into kubernetes:master Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 19, 2021
@chewong chewong deleted the bump-agnhost-to-2.26 branch January 19, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@listx listx Awaiting requested review from listx

Assignees

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chewong @k8s-ci-robot @claudiubelu