Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure bash version at least 5.x #98309

Merged
merged 1 commit into from Jan 24, 2021
Merged

Ensure bash version at least 5.x #98309

merged 1 commit into from Jan 24, 2021

Conversation

dims
Copy link
Member

@dims dims commented Jan 22, 2021 •
edited

Reduce friction by explicitly telling folks that they need newer versions of bash.

Example we use -v:
test -v N' can now test whether or not positional parameter N is set.

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #98294

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2021
@dims
Copy link
Member Author

dims commented Jan 22, 2021

/sig testing
/sig release

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2021
justaugustus
justaugustus requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dims -- Small language nit

hack/lib/util.sh Outdated Show resolved Hide resolved
@SataQiu
Copy link
Member

SataQiu commented Jan 22, 2021

/retest

@dims @justaugustus
Ensure bash version at least 5.x
feecef7 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the ensure-bash-version-at-least-5.x branch from ad3ebca to feecef7 Compare January 22, 2021 18:09
@dims
Copy link
Member Author

dims commented Jan 22, 2021

/assign @justaugustus @BenTheElder

@dims
Copy link
Member Author

dims commented Jan 22, 2021

/retest

@dims
Copy link
Member Author

dims commented Jan 24, 2021

@justaugustus let's get this in please. (needs lgtm)

@justaugustus
Copy link
Member

/lgtm
/approve

FYI @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

/retest

@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit bfe4256 into kubernetes:master Jan 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 24, 2021
@borgerli
Copy link
Contributor

borgerli commented Jan 26, 2021 •
edited

We are still running Ubuntu 18.04(EOL in Apr 2023) with bash 4.4, which supports the "-v" test. This PR make our CI/CD broken.

Do we really need bash 5.x, since bash 4.2+ is OK with -v test?

@dims @justaugustus It would be great if the version restriction is set to version 4.2+. Thank you.

@borgerli borgerli mentioned this pull request Jan 26, 2021
Closed
@mrunalp
Copy link
Contributor

mrunalp commented Jan 28, 2021

@dims This also broke CRI-O CI running on RHEL 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaAndrew JoshuaAndrew JoshuaAndrew left review comments

@justaugustus justaugustus justaugustus requested changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@justaugustus justaugustus

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

build kubernetes binaries failed
8 participants
@dims @k8s-ci-robot @SataQiu @justaugustus @borgerli @mrunalp @JoshuaAndrew @BenTheElder