Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: use recently promoted images #98320

Merged
merged 1 commit into from Jan 29, 2021
Merged

test images: use recently promoted images #98320

merged 1 commit into from Jan 29, 2021

Conversation

chewong
Copy link
Member

@chewong chewong commented Jan 22, 2021 •
edited

Signed-off-by: Ernest Wong chuwon@microsoft.com

What type of PR is this?

Based on #87607.
Part of kubernetes/k8s.io#1522, #96770.

This PR uses test images promoted in kubernetes/k8s.io#1558 and kubernetes/k8s.io#1566.

/sig testing
/sig windows
/kind cleanup
/priority important-soon
/cc @claudiubelu @jsturtevant

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 22, 2021
@claudiubelu
Copy link
Contributor

This is consistent with what I was testing in my PR: #87607

There are a few other images that have been promoted since then. We could bump those later if needed:

  • apparmor-loader
  • metadata-concealment
  • echoserver
  • resource-consumer

@chewong
Copy link
Member Author

chewong commented Jan 26, 2021 •
edited

With kubernetes/k8s.io#1566 merged, I included the following promoted test images in my latest commit:

  • k8s.gcr.io/e2e-test-images/apparmor-loader:1.3
  • k8s.gcr.io/e2e-test-images/echoserver:2.3
  • k8s.gcr.io/e2e-test-images/redis:5.0.5-alpine

I did not include the following images in this PR:

/assign @spiffxp

@jsturtevant jsturtevant added this to In Review (v1.21) in SIG-Windows Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2021
test images: use recently promoted images
40713f7 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2021
@chewong
Copy link
Member Author

chewong commented Jan 28, 2021

/test pull-kubernetes-e2e-aks-engine-azure-windows
/test pull-kubernetes-e2e-aks-engine-windows-contianerd

@chewong
Copy link
Member Author

chewong commented Jan 28, 2021

/retest

@spiffxp
Copy link
Member

spiffxp commented Jan 28, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 28, 2021
spiffxp
spiffxp approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

SIG Node CI/Test Board automation moved this from Triage to PRs - Reviewer lgtm'd Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit eb2b71c into kubernetes:master Jan 29, 2021
SIG-Windows automation moved this from In Review (v1.21) to Done (v1.21) Jan 29, 2021
SIG Node CI/Test Board automation moved this from PRs - Reviewer lgtm'd to Done Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 29, 2021
@chewong chewong deleted the use-promoted-images branch January 29, 2021 01:10
@claudiubelu claudiubelu mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chewong @claudiubelu @spiffxp @k8s-ci-robot