Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ashnehete to CHANGELOG reviewers #98426

Merged
merged 1 commit into from Jan 26, 2021
Merged

Add ashnehete to CHANGELOG reviewers #98426

merged 1 commit into from Jan 26, 2021

Conversation

wilsonehusin
Copy link
Contributor

@wilsonehusin wilsonehusin commented Jan 26, 2021 •
edited

Signed-off-by: Wilson Husin whusin@vmware.com

ashnehete is now a member of Kubernetes organization on GitHub.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add @ashnehete (1.21 Release Notes shadow) to CHANGELOG reviewers

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@wilsonehusin
Add ashnehete to CHANGELOG reviewers
68e600f 
ashnehete is now a member of Kubernetes organization on GitHub.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2021
@wilsonehusin
Copy link
Contributor Author

/triage accepted
/sig release
/area release-eng
/priority important-soon

1.21 Release Lead:
/cc @palnabarun

SIG Release Chairs:
/cc @justaugustus @saschagrunert

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2021
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@liggitt
Copy link
Member

liggitt commented Jan 26, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@palnabarun
Copy link
Member

/lgtm

saschagrunert
saschagrunert approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt, saschagrunert, wilsonehusin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wilsonehusin
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit bae644e into kubernetes:master Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 26, 2021
@wilsonehusin wilsonehusin deleted the patch-2 branch January 26, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

@justaugustus justaugustus Awaiting requested review from justaugustus

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wilsonehusin @justaugustus @liggitt @palnabarun @k8s-ci-robot @saschagrunert