Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: organize unit tests in subtests #98573

Closed
gavinfish opened this issue Jan 29, 2021 · 2 comments · Fixed by #98696
Closed

Scheduler: organize unit tests in subtests #98573

gavinfish opened this issue Jan 29, 2021 · 2 comments · Fixed by #98696
Assignees
@gavinfish
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@gavinfish
Copy link
Contributor

What would you like to be added:

Currently some unit tests in pkg/scheduler is not organized as https://golang.org/pkg/testing/#hdr-Subtests_and_Sub_benchmarks. Use subtests can make it easier to find out which case fails and leverage benefit of parallelism .

Why is this needed:

Follow Go test practice.
@gavinfish gavinfish added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

@gavinfish: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 29, 2021
@gavinfish
Copy link
Contributor Author

/remove-kind feature
/kind cleanup
/sig scheduling

/assign

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2021
This was referenced Jan 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinfish gavinfish

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scheduler: organize scheduler unit tests into subtests gavinfish/kubernetes
2 participants
@gavinfish @k8s-ci-robot