Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating OWNERS_ALIASES for SIG-Windows #98580

Merged
merged 1 commit into from Jul 15, 2021
Merged

Updating OWNERS_ALIASES for SIG-Windows #98580

merged 1 commit into from Jul 15, 2021

Conversation

marosset
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR updates sig-windows-api-reviewers and feature-approvers in owners aliases file.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig windows
/triage accpted

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

@marosset: The label(s) triage/accpted cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR updates sig-windows-api-reviewers and feature-approvers in owners aliases file.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig windows
/triage accpted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

@marosset: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 29, 2021
@marosset marosset changed the title Updating feature-approvers for SIG-Windows Updating OWNERS_ALIASES for SIG-Windows Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2021
@marosset marosset added this to In Review (v1.21) in SIG-Windows Feb 11, 2021
@immuzz immuzz moved this from In Review (v1.21) to In Review (v1.22) in SIG-Windows Mar 11, 2021
@marosset
Copy link
Contributor Author

/retest

@marosset marosset moved this from In Review (v1.22) to In Review (v1.21) in SIG-Windows Mar 11, 2021
@jsturtevant
Copy link
Contributor

@marosset could you rebase this?

@marosset marosset force-pushed the sig-windows-fature-approvers-updates branch from e0e735e to a70323d Compare March 23, 2021 18:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2021
@marosset marosset moved this from In Review (v1.21) to In Review (v1.22) in SIG-Windows Mar 25, 2021
@jsturtevant
Copy link
Contributor

/milestone v1.22
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 22, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 22, 2021
@jsturtevant
Copy link
Contributor

/assign @dchen1107 @wojtek-t

@dims
Copy link
Member

dims commented Jul 15, 2021

/test all
/skip
/assign @liggitt @thockin

Jordan, Tim, this has sig-windows updating their roster, please approve

@liggitt
Copy link
Member

liggitt commented Jul 15, 2021

matches https://github.com/kubernetes/community/tree/master/sig-windows#leadership

/approve

@liggitt
Copy link
Member

liggitt commented Jul 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 15, 2021 •
edited

@marosset: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test e0e735e0ae145bc648b174102c59c810714a8316 link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marosset
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 33070ac into kubernetes:master Jul 15, 2021
SIG-Windows automation moved this from In Review (v1.22) to Done (v1.21) Jul 15, 2021
@marosset marosset deleted the sig-windows-fature-approvers-updates branch July 16, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@thockin thockin

@dchen1107 dchen1107

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marosset @k8s-ci-robot @jsturtevant @dims @liggitt @thockin @dchen1107 @wojtek-t