Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UDP network policies tests #98636

Merged
merged 1 commit into from Feb 14, 2021

Conversation

knabben
Copy link
Member

@knabben knabben commented Jan 31, 2021

What type of PR is this?
/kind feature
/sig network
/area testing

What this PR does / why we need it:
Adding initial UDP coverage for network policy suite test

Which issue(s) this PR fixes:

xref #97640

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jan 31, 2021
@k8s-ci-robot
Copy link
Contributor

@knabben: The label(s) area/testing cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind feature
/sig network
/area testing

What this PR does / why we need it:
Adding initial UDP coverage for network policy suite test

Which issue(s) this PR fixes:

xref #97640

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2021
@k8s-ci-robot
Copy link
Contributor

@knabben: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 31, 2021
@knabben knabben changed the title Adding UDP network policies tests [wip] Adding UDP network policies tests Jan 31, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 31, 2021
@knabben
Copy link
Member Author

knabben commented Jan 31, 2021

Jan 31 17:28:12.706: INFO: Validation of udp-network-policy-6455-z/c -> udp-network-policy-6455-x/a FAILED !!!
Jan 31 17:28:12.706: INFO: error <nil> 
Jan 31 17:28:12.706: INFO: Expected blocked pod connection was instead ALLOWED --- run 'kubectl exec c -c cont-81-udp -n udp-network-policy-6455-z -- nc -v -z -w 1 -u s-udp-network-policy-6455-x-a.udp-network-policy-6455-x.svc.cluster.local 81'

netcat (OpenBSD netcat (Debian patchlevel 1.130)) is exiting with status 0, even when the connection is not really made on UDP.

Not existent port UDP 1404 test with a manual test from the agnhost container:

bash-5.0# nc -v -w 1 -u s-udp-network-policy-529-x-a.udp-network-policy-529-x.svc.cluster.local 1404
Connection to s-udp-network-policy-529-x-a.udp-network-policy-529-x.svc.cluster.local 1404 port [udp/*] succeeded!
bash-5.0# echo $?
0

@knabben knabben mentioned this pull request Jan 31, 2021
7 tasks
@knabben
Copy link
Member Author

knabben commented Feb 1, 2021

Swapping the nc to agnhost connect with UDP after #98639 arrives.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2021
@knabben knabben force-pushed the netpol-udp-tests branch 2 times, most recently from bdf0565 to 2e8fafe Compare February 13, 2021 13:14
@knabben knabben changed the title [wip] Adding UDP network policies tests Adding UDP network policies tests Feb 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2021
@knabben
Copy link
Member Author

knabben commented Feb 14, 2021

/retest

@jayunit100
Copy link
Member

YAYYYyyy UDP netpol tests THANK YOU ~!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, knabben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knabben
Copy link
Member Author

knabben commented Feb 14, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3081b48 into kubernetes:master Feb 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 14, 2021
@knabben knabben deleted the netpol-udp-tests branch February 14, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants