Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DOCKER_CLI_EXPERIMENTAL=enabled for images using buildx #98672

Merged
merged 2 commits into from Feb 1, 2021
Merged

Set DOCKER_CLI_EXPERIMENTAL=enabled for images using buildx #98672

merged 2 commits into from Feb 1, 2021

Conversation

hasheddan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Images using buildx will fail with versions prior to v20.10 due to experimental features being off by default. It is possible the environment will have experimental features enabled, but this explicitly does so if not.

Which issue(s) this PR fixes:

Fixes #98646

Special notes for your reviewer:

@saschagrunert I couldn't immediately identify why the experimental features are enabled in bootstrap but not k8s-ci-builder given that they use almost the exact same setup. This should fix the failure for now, but we should find root cause there and also consider the maintenance burden of trying to keep these two images sort of in sync for now.

/assign @justaugustus @BenTheElder @dims

xref #98569 (comment)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@hasheddan
Build release images with DOCKER_CLI_EXPERIMENTAL enabled
1723719 
In order to use buildx with docker versions prior to v20.10 experimental
features must be enabled. Setting at build time ensures that they are
in case they have not already been at the environment scope.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan
Build conformance image with DOCKER_CLI_EXPERIMENTAL enabled
20679f3 
In order to use buildx with docker versions prior to v20.10 experimental
features must be enabled. Setting at build time ensures that they are
in case they have not already been at the environment scope.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 1, 2021
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 1, 2021
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2021
saschagrunert
saschagrunert approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
@justaugustus
Copy link
Member

Currently breaking the new canary jobs:
/priority critical-urgent

/lgtm
/approve
/triage accepted
/assign @dims
cc: @kubernetes/ci-signal

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 1, 2021
@BenTheElder
Copy link
Member

/lgtm
/approve
I believe we need a follow-up to ensure that there is an initialized builder as well #98569 (comment)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021
@hasheddan
Copy link
Contributor Author

@BenTheElder agreed 👍 getting the job unstuck is priority number one but I will make sure to follow up

@justaugustus
Copy link
Member

Thanks gents! ❤️
I was definitely not expecting to break in this manner when I cut the job over. 😅

@k8s-ci-robot k8s-ci-robot merged commit f81aa3f into kubernetes:master Feb 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 1, 2021
@BenTheElder
Copy link
Member

#98908 to track follow-ups about image builds

@BenTheElder BenTheElder mentioned this pull request Feb 9, 2021
Closed
3 tasks
@BenTheElder BenTheElder mentioned this pull request Feb 20, 2021
Merged
@BenTheElder
Copy link
Member

Presubmit callers of make quick-release are flaking because:

We still need to fully fix this. Will look more later this weekend perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

@stevesloka stevesloka Awaiting requested review from stevesloka

Assignees

@dims dims

@justaugustus justaugustus

@saschagrunert saschagrunert

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

[Failing Test] ci-kubernetes-build-canary does not understand "--platform"
6 participants
@hasheddan @justaugustus @BenTheElder @k8s-ci-robot @saschagrunert @dims