Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that untolerated variable is used as tolerated #98703

Merged
merged 1 commit into from Feb 3, 2021

Conversation

Huang-Wei
Copy link
Member

What type of PR is this?

/kind regression
/sig scheduling
/priority critical-urgent

What this PR does / why we need it:

#98445 introduced a regression that failed all scheduler performance (integration) tests:

F0202 23:48:44.559482 3887158 perf_utils.go:104] Error listing nodes: there are currently no ready, schedulable nodes in the cluster
goroutine 92 [running]:
k8s.io/kubernetes/vendor/k8s.io/klog/v2.stacks(0xc000a7b001, 0xc004d62000, 0x85, 0x14d)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:1026 +0xb9
k8s.io/kubernetes/vendor/k8s.io/klog/v2.(*loggingT).output(0x71fffc0, 0xc000000003, 0x0, 0x0, 0xc001c7a7e0, 0x70b6404, 0xd, 0x68, 0x0)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:975 +0x19b
k8s.io/kubernetes/vendor/k8s.io/klog/v2.(*loggingT).printf(0x71fffc0, 0xc000000003, 0x0, 0x0, 0x0, 0x0, 0x48e4cbb, 0x17, 0xc0077c3770, 0x1, ...)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:750 +0x191
k8s.io/kubernetes/vendor/k8s.io/klog/v2.Fatalf(...)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:1514
k8s.io/kubernetes/test/integration/framework.(*IntegrationTestNodePreparer).PrepareNodes(0xc005f56940, 0x0, 0xc005f0d770, 0x5172660)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/integration/framework/perf_utils.go:104 +0xa26
k8s.io/kubernetes/test/integration/scheduler_perf.runWorkload(0xc0000f5680, 0xc000112b40, 0xc000200d00, 0x0, 0x0, 0x0)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/integration/scheduler_perf/scheduler_perf_test.go:337 +0x121d
k8s.io/kubernetes/test/integration/scheduler_perf.BenchmarkPerfScheduling.func1.1(0xc0000f5680)
        /root/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/integration/scheduler_perf/scheduler_perf_test.go:299 +0x16a
testing.(*B).runN(0xc0000f5680, 0x1)
        /usr/local/go/src/testing/benchmark.go:191 +0xeb
testing.(*B).run1.func1(0xc0000f5680)
        /usr/local/go/src/testing/benchmark.go:231 +0x57
created by testing.(*B).run1
        /usr/local/go/src/testing/benchmark.go:224 +0x7f

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test labels Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 3, 2021
@Huang-Wei
Copy link
Member Author

/cc @damemi @alculquicondor

(scheduler maintainers don't have approving privileges, so)
/assign @oomichi
for kindly review.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

/lgtm
/approve
/triage accepted

/hold
unhold when needed.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@Huang-Wei
Copy link
Member Author

/retest

@Huang-Wei
Copy link
Member Author

Thanks @neolit123 .

/unassign @oomichi
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7655bad into kubernetes:master Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 3, 2021
@damemi
Copy link
Contributor

damemi commented Feb 3, 2021

Sorry I missed this one, but thanks for catching and fixing it @Huang-Wei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants