Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bump CSI container versions for mock testing #98770

Merged
merged 1 commit into from Feb 8, 2021
Merged

test: bump CSI container versions for mock testing #98770

merged 1 commit into from Feb 8, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 4, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

These are the latest stable releases. We should test with those.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

@pohly: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 4, 2021
pacoxu
pacoxu reviewed Feb 5, 2021
View reviewed changes
test/e2e/testing-manifests/storage-csi/mock/csi-mock-driver.yaml Outdated
@@ -29,7 +29,7 @@ spec:
- mountPath: /csi
name: socket-dir
- name: driver-registrar
image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v1.3.0
image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/k8s.io/blob/798f7d6ac63d50dc79e96f5915644fad1f2e851b/k8s.gcr.io/images/k8s-staging-sig-storage/images.yaml#L15
I checked the image list here and find that v2.1.0 is the latest one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, a typo. I was looking at the list of images at https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/US/sig-storage/csi-node-driver-registrar?gcrImageListsize=30 and then swapped digits. 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. Fixed now.

@pohly pohly force-pushed the e2e-mock-container-versions branch from c1635fd to 9732d4e Compare February 5, 2021 08:29
@pacoxu
Copy link
Member

pacoxu commented Feb 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@pohly
Copy link
Contributor Author

pohly commented Feb 5, 2021

/retest

@pohly pohly changed the title test: bump CSI container versions for mock testing WIP: test: bump CSI container versions for mock testing Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2021
@pohly
Copy link
Contributor Author

pohly commented Feb 5, 2021

Hmm, looks like this needs further work: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/98770/pull-kubernetes-e2e-gce-storage-slow/1357607288189227008/

@pohly pohly force-pushed the e2e-mock-container-versions branch from 9732d4e to b67ddda Compare February 5, 2021 12:55
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 5, 2021
@pohly
test: bump CSI container versions for mock testing
d27c541 
These are the latest stable releases. We should test with those.
The newer external-provisioner no longer needs (and doesn't support)
the --provisioner parameter.
@pohly pohly force-pushed the e2e-mock-container-versions branch from b67ddda to d27c541 Compare February 5, 2021 20:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2021
@pohly
Copy link
Contributor Author

pohly commented Feb 5, 2021

/retest

@pohly
Copy link
Contributor Author

pohly commented Feb 5, 2021

/retest

@pohly pohly changed the title WIP: test: bump CSI container versions for mock testing test: bump CSI container versions for mock testing Feb 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2021
@pohly
Copy link
Contributor Author

pohly commented Feb 5, 2021

/retest

@pohly
Copy link
Contributor Author

pohly commented Feb 5, 2021

The newer sidecars needed some command line parameter changes. Should be fixed now.

pacoxu
pacoxu approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021
@pohly
Copy link
Contributor Author

pohly commented Feb 8, 2021

/assign @xing-yang

For approval.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@pohly
Copy link
Contributor Author

pohly commented Feb 8, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit d11e475 into kubernetes:master Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pohly @k8s-ci-robot @pacoxu @xing-yang