Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up pkg/controller/endpointslice unit tests #98793

Merged

Conversation

wzshiming
Copy link
Member

What type of PR is this?
/kind cleanup
/kind flake

What this PR does / why we need it:
35s -> 13s

Which issue(s) this PR fixes:

xref #98486

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

@wzshiming: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2021
@wzshiming
Copy link
Member Author

5s: 0 runs so far, 0 failures
10s: 0 runs so far, 0 failures
15s: 8 runs so far, 0 failures
20s: 8 runs so far, 0 failures
25s: 8 runs so far, 0 failures
30s: 16 runs so far, 0 failures
35s: 16 runs so far, 0 failures
40s: 17 runs so far, 0 failures
45s: 24 runs so far, 0 failures
50s: 24 runs so far, 0 failures
55s: 32 runs so far, 0 failures
1m0s: 32 runs so far, 0 failures
1m5s: 32 runs so far, 0 failures
1m10s: 40 runs so far, 0 failures
1m15s: 40 runs so far, 0 failures
1m20s: 42 runs so far, 0 failures
1m25s: 48 runs so far, 0 failures
1m30s: 48 runs so far, 0 failures
1m35s: 56 runs so far, 0 failures
1m40s: 56 runs so far, 0 failures
1m45s: 56 runs so far, 0 failures
1m50s: 64 runs so far, 0 failures
1m55s: 64 runs so far, 0 failures
2m0s: 70 runs so far, 0 failures
2m5s: 72 runs so far, 0 failures
2m10s: 72 runs so far, 0 failures
2m15s: 80 runs so far, 0 failures
2m20s: 80 runs so far, 0 failures
2m25s: 83 runs so far, 0 failures
2m30s: 88 runs so far, 0 failures
2m35s: 88 runs so far, 0 failures
2m40s: 96 runs so far, 0 failures
2m45s: 96 runs so far, 0 failures
2m50s: 96 runs so far, 0 failures
2m55s: 104 runs so far, 0 failures
3m0s: 104 runs so far, 0 failures
3m5s: 109 runs so far, 0 failures
3m10s: 112 runs so far, 0 failures
3m15s: 112 runs so far, 0 failures
3m20s: 120 runs so far, 0 failures
3m25s: 120 runs so far, 0 failures
3m30s: 124 runs so far, 0 failures
3m35s: 128 runs so far, 0 failures
3m40s: 128 runs so far, 0 failures
3m45s: 136 runs so far, 0 failures
3m50s: 136 runs so far, 0 failures

@robscott
Copy link
Member

robscott commented Feb 5, 2021

Thanks for fixing this @wzshiming! @mborsz can you confirm that there should be no issues running these tests in parallel?

@robscott
Copy link
Member

robscott commented Feb 5, 2021

These tests all look very safe to run in parallel to me, thanks again for fixing this!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2021
@pacoxu
Copy link
Member

pacoxu commented Feb 5, 2021

/retest

1 similar comment
@pacoxu
Copy link
Member

pacoxu commented Feb 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit c15851b into kubernetes:master Feb 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 6, 2021
@wzshiming wzshiming deleted the ut/speed-up-endpointslice branch February 9, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants