Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: improve error message about node subnet size validation #98796

Merged
merged 1 commit into from Feb 6, 2021
Merged

kubeadm: improve error message about node subnet size validation #98796

merged 1 commit into from Feb 6, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 5, 2021 •
edited

What type of PR is this?
/kind cleanup
What this PR does / why we need it:

[root@master-dce4 ~]# kubeadm init --feature-gates IPv6DualStack=true --pod-network-cidr="172.30.0.0/26,fdff:ffff:ffff:ffff:0:0::/96" --service-cidr="172.31.0.0/16,fdff:ffff:ffff:ffff:0:1::/108" --dry-run
[podSubnet: Invalid value: "172.30.0.0/26": pod subnet size is smaller than the node subnet size, podSubnet: Invalid value: "fdff:ffff:ffff:ffff::/96": pod subnet size is smaller than the node subnet size]

When I try to install kubeadm with dual-stack enabled, I got the error above. The subnet is smaller than node subnet size. But it doesn't print the node subnet size.

Which issue(s) this PR fixes:
part of kubernetes/kubeadm#1612

  • will working on kubeadm dual-stack 1.21 supports.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2021
@pacoxu pacoxu requested a review from aojea February 5, 2021 09:47
@pacoxu
Copy link
Member Author

pacoxu commented Feb 5, 2021 •
edited

Thanks for the review.
squashed the commit per your comments @aojea

@aojea
Copy link
Member

aojea commented Feb 5, 2021

/lgtm
/assign @neolit123

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
SataQiu
SataQiu reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pacoxu!
add some comments.

cmd/kubeadm/app/apis/kubeadm/validation/validation.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/apis/kubeadm/validation/validation.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/apis/kubeadm/validation/validation.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@SataQiu
Copy link
Member

SataQiu commented Feb 5, 2021

FYI: Similar PR #98785

@pacoxu
Copy link
Member Author

pacoxu commented Feb 5, 2021 •
edited

FYI: Similar PR #98785
@SataQiu Thanks for your comments.
It makes sense to me. I accepted your comments and squashed the commits.

@driazati Sorry for dup fix on the same thing. Feel free to include/combine this PR in your PR if you like, and close this after #98785 is merged. There are some review comments here that might make sense.

@SataQiu
Copy link
Member

SataQiu commented Feb 5, 2021

/cc @neolit123 @fabriziopandini

@pacoxu @aojea
@SataQiu @neolit123
kubeadm: improve error message about node subnet size validation
f681edf 
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
Co-authored-by: SataQiu <1527062125@qq.com>
Co-authored-by: driazati <david.riazati@gatech.edu>
Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com>
neolit123
neolit123 reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm
/approve

@pacoxu
Copy link
Member Author

pacoxu commented Feb 5, 2021

Thanks for all your comments.

  • I think I need an English training. 😭

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@neolit123
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@aojea
Copy link
Member

aojea commented Feb 5, 2021

  • I think I need an English training. sob

hahah I think that none of the reviewers is english native, so let´s merge before one sees this and correct us all ;)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@aojea
Copy link
Member

aojea commented Feb 5, 2021

?? what happen @pacoxu ??

@pacoxu
Copy link
Member Author

pacoxu commented Feb 5, 2021 •
edited

squashed the commit @aojea haha

@neolit123
Copy link
Member

hahah I think that none of the reviewers is english native, so let´s merge before one sees this and correct us all ;)

yeah, all of us are doing a best effort on that front 👍

@neolit123
Copy link
Member

/retest
looks like a pkg/kubelet flake.

@driazati driazati mentioned this pull request Feb 5, 2021
Closed
SataQiu
SataQiu reviewed Feb 6, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 25d5d65 into kubernetes:master Feb 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 6, 2021
@pacoxu pacoxu deleted the kubeadm/dual-stack-1 branch June 23, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@aojea aojea aojea left review comments

@SataQiu SataQiu SataQiu left review comments

@yagonobre yagonobre Awaiting requested review from yagonobre

@yastij yastij Awaiting requested review from yastij

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@neolit123 neolit123

@aojea aojea

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pacoxu @aojea @SataQiu @neolit123 @k8s-ci-robot