Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e/storage-csi: replace gcr.io/gke-release to the community registry k8s.gcr.io/sig-storage #98805

Merged
merged 1 commit into from Feb 6, 2021
Merged

e2e/storage-csi: replace gcr.io/gke-release to the community registry k8s.gcr.io/sig-storage #98805

merged 1 commit into from Feb 6, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 5, 2021 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Change the images used in the test from gcr.io/gke-release to use the community registry in this case k8s.gcr.io/sig-storage

Slack 🧵 https://kubernetes.slack.com/archives/C09QZFCE5/p1611747322028100

/assign @spiffxp @msau42

Which issue(s) this PR fixes:

Fixes partially kubernetes/k8s.io#1525

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2021
cpanato
cpanato commented Feb 5, 2021
View reviewed changes
test/e2e/testing-manifests/storage-csi/gce-pd/controller_ss.yaml Outdated
args:
- "--v=5"
- "--csi-address=/csi/csi.sock"
volumeMounts:
- name: socket-dir
mountPath: /csi
- name: csi-resizer
image: gcr.io/gke-release/csi-resizer:v0.5.0-gke.0
image: k8s.gcr.io/sig-storage/csi-resizer:v0.5.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw there is updated images v0.5.1 and even v1.1.0 https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/images/k8s-staging-sig-storage/images.yaml#L28-L35

should we update to use the path release or upgrade to 1.1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah upgrading to 1.1.0 is fine, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
To address this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @spiffxp PTAL

how we will deal with this image gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver:v1.0.1-gke.0 per my comment #98805 (review)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrading to 1.1.0 looks like now we have some timeouts :/

cpanato
cpanato commented Feb 5, 2021
View reviewed changes
Copy link
Member Author

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this: https://github.com/kubernetes/kubernetes/pull/98805/files#diff-1e966d5d795fba59a8ceea256e18d4390e98c4b6fc5adeb135397ab391598174R58

looks like does not exist in the community registry here this is built? or it is easier to just copy to the new registry?

@cpanato
Copy link
Member Author

cpanato commented Feb 5, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 5, 2021
@cpanato
Copy link
Member Author

cpanato commented Feb 5, 2021

/test pull-kubernetes-bazel-test

msau42
msau42 reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

test/e2e/testing-manifests/storage-csi/gce-pd/controller_ss.yaml Outdated
args:
- "--v=5"
- "--csi-address=/csi/csi.sock"
volumeMounts:
- name: socket-dir
mountPath: /csi
- name: csi-resizer
image: gcr.io/gke-release/csi-resizer:v0.5.0-gke.0
image: k8s.gcr.io/sig-storage/csi-resizer:v0.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah upgrading to 1.1.0 is fine, thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
spiffxp
spiffxp approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will lgtm once hold is address

test/e2e/testing-manifests/storage-csi/gce-pd/controller_ss.yaml Outdated
args:
- "--v=5"
- "--csi-address=/csi/csi.sock"
volumeMounts:
- name: socket-dir
mountPath: /csi
- name: csi-resizer
image: gcr.io/gke-release/csi-resizer:v0.5.0-gke.0
image: k8s.gcr.io/sig-storage/csi-resizer:v0.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
To address this

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, msau42, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Feb 6, 2021

/test pull-kubernetes-bazel-test
/test pull-kubernetes-conformance-kind-ipv6-parallel

@cpanato
Copy link
Member Author

cpanato commented Feb 6, 2021

/test pull-kubernetes-e2e-gce-csi-serial

@k8s-ci-robot
Copy link
Contributor

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-csi-serial c9ccfe6 link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

spiffxp
spiffxp reviewed Feb 6, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4db3c93 into kubernetes:master Feb 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 6, 2021
@cpanato cpanato deleted the k8sio-GH-1525-csi branch February 6, 2021 18:37
@thejoycekung thejoycekung mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@msau42 msau42 msau42 left review comments

@gnufied gnufied Awaiting requested review from gnufied

@verult verult Awaiting requested review from verult

Assignees

@spiffxp spiffxp

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpanato @k8s-ci-robot @spiffxp @msau42