Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricsGrabber tests failing when scheduler & controller-manager not visible #98894

Closed
jkaniuk opened this issue Feb 8, 2021 · 3 comments · Fixed by #98972
Closed

MetricsGrabber tests failing when scheduler & controller-manager not visible #98894

jkaniuk opened this issue Feb 8, 2021 · 3 comments · Fixed by #98972
Assignees
@dashpole
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jkaniuk
Copy link
Contributor

jkaniuk commented Feb 8, 2021

MetricsGrabber tests failing when scheduler & controller-manager not visible.

In managed offerings, like GKE, scheduler and controller-manager are not visible causing BeforeSuite of MetricsGrabber to fail.
Test is failing then control plane pods can't be found (as on GKE):

test/e2e/instrumentation/monitoring/metrics_grabber.go#50

			if !grabber.HasControlPlanePods() {
				return fmt.Errorf("unable to get find control plane pods")
			}

test/e2e/framework/metrics/metrics_grabber.go#121

func (g *Grabber) HasControlPlanePods() bool {
	return g.kubeScheduler != "" && g.kubeControllerManager != ""
}

HasControlPlanePods was added in 20863a8

/assign @dashpole
@jkaniuk jkaniuk added the kind/bug Categorizes issue or PR as related to a bug. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2021
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Feb 8, 2021

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2021
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Feb 8, 2021

Just removing this check allows tests to run without problems (some skipped, one passing).

@dashpole
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 10, 2021
@dashpole dashpole mentioned this issue Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MetricsGrabber test by skipping if the master node isn't registered dashpole/kubernetes
3 participants
@dashpole @jkaniuk @k8s-ci-robot