New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Machinery: Add equal func for Requirement struct #99083
Conversation
/assign @caesarxuchao |
/triage accepted |
Curious in what respects cmp.Equal works better than reflect.DeepEqual for internalSelector? Can you make an example? Anyway, this PR looks good. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, gavinfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For internalSelector, there is no big difference since all fields matter. But for other structs holding Selector(internalSelector) as a field, we need use |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add Equal func for
Requirement
struct. This is useful when we need compareRequirement
andSelector
with cmp lib.Which issue(s) this PR fixes:
Xref #94696
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: