Return error when persister fails to modify config

[databus23]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently the config persister silently discards errors that happen when trying to persist config changes.
In my case a stale lock file caused all changes to the config to fail. As refreshed oidc tokens could not per persisted I ended up with a broken oidc authconfig every time the idToken expired.

The swallowed error in my case was:

could not persist new tokens: open /Users/[SNIPPED]/.kube/config.lock: file exists

Special notes for your reviewer:

NONE

[k8s-ci-robot]

Hi @databus23. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fedebongio]

/assign @soltysh
/remove-sig api-machinery
/sig cli

[rikatz]

/ok-to-test
/assign
/cc

[rikatz]

/test pull-kubernetes-e2e-kind-ipv6

[rikatz]

/lgtm
Thank you!

[rikatz]

/triage accepted
/priority backlog

[dougsland]

/lgtm

[soltysh]

/lgtm
/approve

[deads2k]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: databus23, deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/client-go/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment