Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conflict hostPort e2e test #99112

Merged
merged 1 commit into from Feb 17, 2021
Merged

fix conflict hostPort e2e test #99112

merged 1 commit into from Feb 17, 2021

Conversation

JornShen
Copy link
Member

What type of PR is this?

/kind bug
/kind flake
/kind failing-test

What this PR does / why we need it:

fix network test: [sig-network] HostPort validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance]

failed link:
https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-e2e-kind-ipv6
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/99098/pull-kubernetes-e2e-kind-ipv6/1361354037437403136/

From the logs of kubelet. pod create no success. The test go through it checking pod no pending.
I think it is no enough to support the following test check.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 16, 2021
@k8s-ci-robot
Copy link
Contributor

@JornShen: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 16, 2021
@JornShen
Copy link
Member Author

/cc @aojea

@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 16, 2021
aojea
aojea reviewed Feb 16, 2021
View reviewed changes
test/e2e/network/hostport.go Outdated Show resolved Hide resolved
@aojea
Copy link
Member

aojea commented Feb 16, 2021

/retest
/lgtm
Thank you very much
/assign @BenTheElder @spiffxp
this affects conformance

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@JornShen JornShen force-pushed the fix-e2etest-validates-same-hostport-in-same-node branch from a10610c to 8502eb7 Compare February 16, 2021 14:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@JornShen
Copy link
Member Author

updated. @aojea
recc

@aojea
Copy link
Member

aojea commented Feb 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@oomichi
Copy link
Member

oomichi commented Feb 16, 2021

/test pull-kubernetes-conformance-kind-ga-only-parallel
/lgtm

@BenTheElder
Copy link
Member

@aojea in what way? seems to me this is functionally from a conformance POV is equivilant?

@JornShen JornShen force-pushed the fix-e2etest-validates-same-hostport-in-same-node branch from 8502eb7 to 6b8781c Compare February 17, 2021 04:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@JornShen
Copy link
Member Author

updated.
@BenTheElder

@aojea
Copy link
Member

aojea commented Feb 17, 2021

@aojea in what way? seems to me this is functionally from a conformance POV is equivilant?

Bad wording, just wanted to say that touches a conformance test to give the pr my priority, not meaning it changes it behaviour sorry
/Lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@oomichi
Copy link
Member

oomichi commented Feb 17, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JornShen, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit a1c7e52 into kubernetes:master Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea aojea left review comments

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

@oomichi oomichi

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JornShen @k8s-ci-robot @aojea @oomichi @BenTheElder @spiffxp