Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: improve error message for client-side SMP for CRs #99143

Merged
merged 1 commit into from Feb 19, 2021
Merged

kubectl: improve error message for client-side SMP for CRs #99143

merged 1 commit into from Feb 19, 2021

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Feb 17, 2021

Fixes #97423
Ref: #97423 (comment)
/kind cleanup
/priority backlog

Does this PR introduce a user-facing change?

NONE

cc @palnabarun

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 17, 2021
@nikhita nikhita mentioned this pull request Feb 17, 2021
Closed
@nikhita nikhita changed the title kubectl: fix error message for client-side SMP for CRs kubectl: improve error message for client-side SMP for CRs Feb 17, 2021
@pacoxu
Copy link
Member

pacoxu commented Feb 17, 2021

/test pull-kubernetes-bazel-test

--- FAIL: TestMultithreadedThrottling (0.99s)
throttle_test.go:71: Expected it to take at least 1 second to get 100 tokens, took 986.866079ms

kubernetes/staging/src/k8s.io/client-go/util/flowcontrol/throttle_test.go

Line 68 in cea1d4e

// tolerate a 1% clock change because these things happen

It tolerates 1% clock change which is trick.

@dougsland
Copy link
Member

/triage accepted
/priority backlog
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@pacoxu pacoxu mentioned this pull request Feb 17, 2021
Closed
@palnabarun
Copy link
Member

/lgtm

@nikhita
Copy link
Member Author

nikhita commented Feb 18, 2021

/assign @apelisse
for approval

@apelisse
Copy link
Member

Thanks!
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

soltysh
soltysh approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, nikhita, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 6dba3f2 into kubernetes:master Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 19, 2021
@nikhita nikhita deleted the cr-smp-msg branch February 19, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dims dims Awaiting requested review from dims

@zhouya0 zhouya0 Awaiting requested review from zhouya0

Assignees

@soltysh soltysh

@dougsland dougsland

@apelisse apelisse

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

kubectl fails to apply strategic merge patch to custom resource
8 participants
@nikhita @pacoxu @dougsland @palnabarun @apelisse @fejta-bot @k8s-ci-robot @soltysh