Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #98555: Storage e2e: Remove pd csi driver installation in GKE #99166

Merged
merged 1 commit into from Mar 4, 2021
Merged

Automated cherry pick of #98555: Storage e2e: Remove pd csi driver installation in GKE #99166

merged 1 commit into from Mar 4, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented Feb 17, 2021 •
edited

Cherry pick of #98555 on release-1.19.

#98555: Storage e2e: Remove pd csi driver installation in GKE

For details on the cherry pick process, see the cherry pick requests page.

Notes: This fixes conflicting PD CSI driver installations in GKE storage e2e tests.

NONE

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 17, 2021
@verult verult force-pushed the automated-cherry-pick-of-#98555-upstream-release-1.19 branch from f93316e to c6313d9 Compare February 17, 2021 22:44
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 17, 2021
@verult
Copy link
Contributor Author

verult commented Feb 17, 2021 •
edited

/kind bug
/priority critical-urgent
/triage accepted
/assign @msau42 @mattcary

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 17, 2021
@k8s-ci-robot
Copy link
Contributor

@verult: GitHub didn't allow me to assign the following users: Cary, Michelle, Au, Matt.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/kind bug
/priority critical-urgent
/triage accepted
/assign Michelle Au Matt Cary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2021
@verult
Copy link
Contributor Author

verult commented Feb 17, 2021

/assign @msau42 @mattcary

@msau42
Copy link
Member

msau42 commented Feb 17, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2021
@verult
Copy link
Contributor Author

verult commented Feb 17, 2021

/test pull-kubernetes-node-e2e

@verult
Copy link
Contributor Author

verult commented Feb 17, 2021

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind

@mattcary
Copy link
Contributor

/lgtm

hasheddan
hasheddan approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, msau42, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit f395d6b into kubernetes:release-1.19 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@copejon copejon Awaiting requested review from copejon

@davidz627 davidz627 Awaiting requested review from davidz627

Assignees

@msau42 msau42

@hasheddan hasheddan

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@verult @k8s-ci-robot @msau42 @mattcary @hasheddan